Checking for size of outgoing and incoming edges of the vertex after removing a single edge #771

Merged
merged 1 commit into from Jun 7, 2013

Projects

None yet

3 participants

@prathamesh-sonpatki
Contributor
  • After removing all incoming or outgoing edges, incoming or outgoing
    edges of a vertex are set to null
  • But after removing a single edge, it is not checked that outgoing of
    the source or incoming of the destination should be changed to null
    or not
  • This commit checks that condition and sets outgoing and incoming of
    source and destination respectively to null if the condition is met.
@subbuss subbuss was assigned Jun 7, 2013
@BanzaiMan
Member

We fixed CI. Could you rebase this PR off 0ccfa36 and try again?

(Also, @enebo and @subbuss, please review this PR.)

@prathamesh-sonpatki prathamesh-sonpatki Checking for size of outgoing and incoming edges of the vertex after
removing a single edge

- After removing all incoming or outgoing edges, incoming or outgoing
  edges of a vertex are set to null
- But after removing a single edge, it is not checked that outgoing of
  the source or incoming of the destination should be changed to null
  or not
- This commit checks that condition and sets outgoing and incoming of
  source and destination respectively to null if the condition is met.
b69e141
@BanzaiMan BanzaiMan merged commit fbd6c9d into jruby:master Jun 7, 2013

1 check passed

default The Travis CI build passed
Details
@BanzaiMan
Member

On a second thought, the patch looks reasonable to me. I also added spec:ir task to Travis, so we run them in CI.

@prathamesh-sonpatki prathamesh-sonpatki deleted the prathamesh-sonpatki:vertex_specs branch Jun 8, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment