Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checking for size of outgoing and incoming edges of the vertex after removing a single edge #771

Merged
merged 1 commit into from Jun 7, 2013

Conversation

Projects
None yet
3 participants
@prathamesh-sonpatki
Copy link
Contributor

commented May 26, 2013

  • After removing all incoming or outgoing edges, incoming or outgoing
    edges of a vertex are set to null
  • But after removing a single edge, it is not checked that outgoing of
    the source or incoming of the destination should be changed to null
    or not
  • This commit checks that condition and sets outgoing and incoming of
    source and destination respectively to null if the condition is met.

@ghost ghost assigned subbuss Jun 7, 2013

@BanzaiMan

This comment has been minimized.

Copy link
Member

commented Jun 7, 2013

We fixed CI. Could you rebase this PR off 0ccfa36 and try again?

(Also, @enebo and @subbuss, please review this PR.)

Checking for size of outgoing and incoming edges of the vertex after
removing a single edge

- After removing all incoming or outgoing edges, incoming or outgoing
  edges of a vertex are set to null
- But after removing a single edge, it is not checked that outgoing of
  the source or incoming of the destination should be changed to null
  or not
- This commit checks that condition and sets outgoing and incoming of
  source and destination respectively to null if the condition is met.
@prathamesh-sonpatki

This comment has been minimized.

Copy link
Contributor Author

commented Jun 7, 2013

BanzaiMan added a commit that referenced this pull request Jun 7, 2013

Merge pull request #771 from prathamesh-sonpatki/vertex_specs
Checking for size of outgoing and incoming edges of the vertex after removing a single edge

@BanzaiMan BanzaiMan merged commit fbd6c9d into jruby:master Jun 7, 2013

1 check passed

default The Travis CI build passed
Details
@BanzaiMan

This comment has been minimized.

Copy link
Member

commented Jun 7, 2013

On a second thought, the patch looks reasonable to me. I also added spec:ir task to Travis, so we run them in CI.

@prathamesh-sonpatki prathamesh-sonpatki deleted the prathamesh-sonpatki:vertex_specs branch Jun 8, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.