Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Tag intermittent spec failures #780

Merged
merged 1 commit into from

2 participants

Daniel Marcotte Charles Oliver Nutter
Daniel Marcotte

This should improve the stability of the Travis build. Most of these failures are explained in #779 (and marked as such). For the other two:

  • IO#close on an IO.popen stream sets $? can been seen failing for no good reason here (Note also that this is not a new tag; it simply fixes the tag so that it gets picked up by the build. Copied from the existing tag for 1.8)
  • Process.kill accepts a signal name without the 'SIG' prefix can be seen failing for no good reason here
Daniel Marcotte dmarcotte Tag some unstable specs
Tag a number of specs which have proven to cause intermittent failures.

Note that this fixes up the tag for the unstable close_spec which was
not being picked up by the tests.
34587b0
Daniel Marcotte

Quick update on this: Travis has been really clean lately except when it fails on the tests this pull tags. For instance, the last four runs should have been green:

https://travis-ci.org/jruby/jruby/builds/7947845
https://travis-ci.org/jruby/jruby/builds/7953655
https://travis-ci.org/jruby/jruby/builds/7953754
https://travis-ci.org/jruby/jruby/builds/7954515

I'm imagining this hasn't been merged yet to wait and see if these continue coming up (which totally makes sense), so I figured it might be helpful to note they're still an issue.

(I also just rebased this branch and re-pushed to trigger a new build. My original push coincided with the tests being in bad shape; my bad)

Charles Oliver Nutter
Owner

Ok, merging. I may look at marking these with something other than "fails" since that's the tag we use for stuff known to be unimplemented or buggy; we use e.g. "critical" for failures that are intermittent, bad specs, or environment-unfriendly.

Charles Oliver Nutter headius merged commit 0041803 into from
Daniel Marcotte

Ah, thanks for the heads up. I should have noticed there's an "unstable" tag, which is clearly more appropriate here. I'll send a follow-up cleaning this up.

Charles Oliver Nutter
Owner
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jun 11, 2013
  1. Daniel Marcotte

    Tag some unstable specs

    dmarcotte authored
    Tag a number of specs which have proven to cause intermittent failures.
    
    Note that this fixes up the tag for the unstable close_spec which was
    not being picked up by the tests.
This page is out of date. Refresh to see the latest.
1  spec/tags/1.8/ruby/core/process/kill_tags.txt
View
@@ -1,2 +1,3 @@
windows(JRUBY-4317):Process.kill raises an ArgumentError for unknown signals
fails:Process.kill raises a TypeError if the PID is not a Fixnum
+fails(travis,intermittent):Process.kill accepts a signal name without the 'SIG' prefix
1  spec/tags/1.9/ruby/core/io/close_spec.txt
View
@@ -1 +0,0 @@
-failed:IO#close on an IO.popen stream sets $?
1  spec/tags/1.9/ruby/core/io/close_tags.txt
View
@@ -0,0 +1 @@
+fails(JRUBY-4110,linux,intermittent failure):IO#close on an IO.popen stream sets $?
37 spec/tags/1.9/ruby/core/kernel/spawn_tags.txt
View
@@ -88,3 +88,40 @@ fails:Kernel.spawn does NOT redirect both STDERR and STDOUT at the time to the g
fails:Kernel#spawn with multiple arguments preserves whitespace in passed arguments
fails(only in full runs):Kernel#spawn with multiple arguments calls #to_str to convert the arguments to Strings
fails(only in full runs):Kernel.spawn with multiple arguments does not subject the arguments to shell expansion
+fails(intermittent, gh-779):Kernel#spawn with multiple arguments does not subject the arguments to shell expansion
+fails(intermittent, gh-779):Kernel.spawn with a single argument creates an argument array with shell parsing semantics for whitespace
+fails(intermittent, gh-779):Kernel.spawn with a command array preserves whitespace in passed arguments
+fails(intermittent, gh-779):Kernel#spawn with a single argument subjects the specified command to shell expansion
+fails(intermittent, gh-779):Kernel#spawn with a single argument creates an argument array with shell parsing semantics for whitespace
+fails(intermittent, gh-779):Kernel#spawn with a single argument calls #to_str to convert the argument to a String
+fails(intermittent, gh-779):Kernel#spawn with a command array does not subject the arguments to shell expansion
+fails(intermittent, gh-779):Kernel#spawn with a command array preserves whitespace in passed arguments
+fails(intermittent, gh-779):Kernel#spawn with a command array calls #to_str to convert the first element to a String
+fails(intermittent, gh-779):Kernel.spawn with a single argument subjects the specified command to shell expansion
+fails(intermittent, gh-779):Kernel.spawn with a single argument calls #to_str to convert the argument to a String
+fails(intermittent, gh-779):Kernel.spawn with multiple arguments preserves whitespace in passed arguments
+fails(intermittent, gh-779):Kernel.spawn with multiple arguments calls #to_str to convert the arguments to Strings
+fails(intermittent, gh-779):Kernel.spawn with a command array calls #to_str to convert the first element to a String
+fails(intermittent, gh-779):Kernel.spawn with a command array calls #to_str to convert the second element to a String
+fails(intermittent, gh-779):Kernel#spawn sets environment variables in the child environment
+fails(intermittent, gh-779):Kernel#spawn calls #to_hash to convert the environment
+fails(intermittent, gh-779):Kernel#spawn does not unset other environment variables when given a false :unsetenv_others option
+fails(intermittent, gh-779):Kernel#spawn does not unset other environment variables when given a nil :unsetenv_others option
+fails(intermittent, gh-779):Kernel#spawn does not unset environment variables included in the environment hash
+fails(intermittent, gh-779):Kernel#spawn joins the current process group by default
+fails(intermittent, gh-779):Kernel#spawn joins the current process if :pgroup => false
+fails(intermittent, gh-779):Kernel#spawn joins the current process if :pgroup => nil
+fails(intermittent, gh-779):Kernel#spawn joins the specified process group if :pgroup => pgid
+fails(intermittent, gh-779):Kernel#spawn uses the current working directory as its working directory
+fails(intermittent, gh-779):Kernel#spawn uses the current umask by default
+fails(intermittent, gh-779):Kernel.spawn sets environment variables in the child environment
+fails(intermittent, gh-779):Kernel.spawn calls #to_hash to convert the environment
+fails(intermittent, gh-779):Kernel.spawn does not unset other environment variables when given a false :unsetenv_others option
+fails(intermittent, gh-779):Kernel.spawn does not unset other environment variables when given a nil :unsetenv_others option
+fails(intermittent, gh-779):Kernel.spawn does not unset environment variables included in the environment hash
+fails(intermittent, gh-779):Kernel.spawn joins the current process group by default
+fails(intermittent, gh-779):Kernel.spawn joins the current process if :pgroup => false
+fails(intermittent, gh-779):Kernel.spawn joins the current process if :pgroup => nil
+fails(intermittent, gh-779):Kernel.spawn joins the specified process group if :pgroup => pgid
+fails(intermittent, gh-779):Kernel.spawn uses the current umask by default
+fails(intermittent, gh-779):Kernel#spawn with a command array calls #to_str to convert the second element to a String
1  spec/tags/1.9/ruby/core/process/kill_tags.txt
View
@@ -1 +1,2 @@
windows(JRUBY-4317):Process.kill raises an ArgumentError for unknown signals
+fails(travis,intermittent):Process.kill accepts a signal name without the 'SIG' prefix
20 spec/tags/1.9/ruby/core/process/spawn_tags.txt
View
@@ -40,3 +40,23 @@ fails(only in rake run?):Kernel#spawn returns the process ID of the new process
fails:Process.spawn returns the process ID of the new process as a Fixnum
fails(gh-631):Process.spawn with a single argument creates an argument array with shell parsing semantics for whitespace
fails(gh-631):Process.spawn with multiple arguments preserves whitespace in passed arguments
+fails(intermittent, gh-779):Process.spawn with a command array does not subject the arguments to shell expansion
+fails(intermittent, gh-779):Process.spawn with a single argument calls #to_str to convert the argument to a String
+fails(intermittent, gh-779):Process.spawn with a single argument subjects the specified command to shell expansion
+fails(intermittent, gh-779):Process.spawn with multiple arguments does not subject the arguments to shell expansion
+fails(intermittent, gh-779):Process.spawn with multiple arguments calls #to_str to convert the arguments to Strings
+fails(intermittent, gh-779):Process.spawn with a command array preserves whitespace in passed arguments
+fails(intermittent, gh-779):Process.spawn with a command array calls #to_str to convert the first element to a String
+fails(intermittent, gh-779):Process.spawn with a command array calls #to_str to convert the second element to a String
+fails(intermittent, gh-779):Process.spawn executes the given command
+fails(intermittent, gh-779):Process.spawn sets environment variables in the child environment
+fails(intermittent, gh-779):Process.spawn calls #to_hash to convert the environment
+fails(intermittent, gh-779):Process.spawn does not unset other environment variables when given a false :unsetenv_others option
+fails(intermittent, gh-779):Process.spawn does not unset other environment variables when given a nil :unsetenv_others option
+fails(intermittent, gh-779):Process.spawn does not unset environment variables included in the environment hash
+fails(intermittent, gh-779):Process.spawn joins the current process group by default
+fails(intermittent, gh-779):Process.spawn joins the current process if :pgroup => false
+fails(intermittent, gh-779):Process.spawn joins the current process if :pgroup => nil
+fails(intermittent, gh-779):Process.spawn joins the specified process group if :pgroup => pgid
+fails(intermittent, gh-779):Process.spawn uses the current working directory as its working directory
+fails(intermittent, gh-779):Process.spawn uses the current umask by default
Something went wrong with that request. Please try again.