Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag intermittent spec failures #780

Merged
merged 1 commit into from Jun 11, 2013

Conversation

Projects
None yet
2 participants
@dmarcotte
Copy link
Contributor

dmarcotte commented May 30, 2013

This should improve the stability of the Travis build. Most of these failures are explained in #779 (and marked as such). For the other two:

  • IO#close on an IO.popen stream sets $? can been seen failing for no good reason here (Note also that this is not a new tag; it simply fixes the tag so that it gets picked up by the build. Copied from the existing tag for 1.8)
  • Process.kill accepts a signal name without the 'SIG' prefix can be seen failing for no good reason here
Tag some unstable specs
Tag a number of specs which have proven to cause intermittent failures.

Note that this fixes up the tag for the unstable close_spec which was
not being picked up by the tests.
@dmarcotte

This comment has been minimized.

Copy link
Contributor Author

dmarcotte commented Jun 11, 2013

Quick update on this: Travis has been really clean lately except when it fails on the tests this pull tags. For instance, the last four runs should have been green:

https://travis-ci.org/jruby/jruby/builds/7947845
https://travis-ci.org/jruby/jruby/builds/7953655
https://travis-ci.org/jruby/jruby/builds/7953754
https://travis-ci.org/jruby/jruby/builds/7954515

I'm imagining this hasn't been merged yet to wait and see if these continue coming up (which totally makes sense), so I figured it might be helpful to note they're still an issue.

(I also just rebased this branch and re-pushed to trigger a new build. My original push coincided with the tests being in bad shape; my bad)

@headius

This comment has been minimized.

Copy link
Member

headius commented Jun 11, 2013

Ok, merging. I may look at marking these with something other than "fails" since that's the tag we use for stuff known to be unimplemented or buggy; we use e.g. "critical" for failures that are intermittent, bad specs, or environment-unfriendly.

headius added a commit that referenced this pull request Jun 11, 2013

Merge pull request #780 from dmarcotte/unstable-tests
Tag intermittent spec failures

@headius headius merged commit 0041803 into jruby:master Jun 11, 2013

1 check passed

default The Travis CI build passed
Details
@dmarcotte

This comment has been minimized.

Copy link
Contributor Author

dmarcotte commented Jun 11, 2013

Ah, thanks for the heads up. I should have noticed there's an "unstable" tag, which is clearly more appropriate here. I'll send a follow-up cleaning this up.

@headius

This comment has been minimized.

Copy link
Member

headius commented Jun 11, 2013

Oops...I forgot about "unstable" too and used "critical". Will replace with
your PR.

Ah, thanks for the heads up. I should have noticed there's an "unstable"
tag, which is clearly more appropriate here. I'll send a follow-up cleaning
this up.


Reply to this email directly or view it on GitHubhttps://github.com//pull/780#issuecomment-19275046
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.