Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix enum arg handling in Enumerator Nexter #815

merged 1 commit into from Jun 21, 2013


Copy link

@dmarcotte dmarcotte commented Jun 20, 2013

This fixes #264. I noticed that issue had the same symptoms that #807 addressed for each_with_index. This pull extends the #807 fix to cover the next case.

Note also that the regression test == nil added here actually hangs prior to this fix (the nexter queue blocked forever waiting for a value that's not coming; now we explicitly feed it the nil), so avoiding that is a nice bonus.

Between the updated arg handing and avoiding that hang, it seems like there's a chance some specs can be untagged now... I'll have a look soon.

The Nexter for Enumerators needs to have its enum args packed in the
same way as each_with_index.  Refactor the arg handling in EachWithIndex
to cover this case too.
Copy link
Contributor Author

@dmarcotte dmarcotte commented Jun 21, 2013

Hrm... I see Travis didn't like this pull, but that must be a red herring: I got a clean run on my branch.

Thoughts on the failures noted for this pull: the timeout problem is probably intermittent (needs a tag?), and we can see the String#sub with pattern and block restores $~ after leaving the block failure (here and here) also fail in this unrelated build.

Hope that helps!

Copy link

@headius headius commented Jun 21, 2013

@dmarcotte: I will give your patch a run locally, and see if we need some additional tags to stabilize those failures. Thanks!

@jrubyci jrubyci merged commit e23e804 into jruby:master Jun 21, 2013
1 check failed
1 check failed
default The Travis CI build failed

This comment has been minimized.

Copy link

@kachick kachick commented on e23e804 Jun 22, 2013

🍣 Great :)

@dmarcotte dmarcotte deleted the dmarcotte:enum_args branch Jul 1, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants