fix #823 #824

Merged
merged 1 commit into from Jun 24, 2013

Projects

None yet

2 participants

@sclasen
Contributor
sclasen commented Jun 24, 2013

Applied the fix from jruby/jruby-ossl#7 built jruby and used the build to run my broken test, which passed.

@headius
Member
headius commented Jun 24, 2013

The fix passed all tests except one, so I'll go ahead with a merge. Do you perhaps have a small test case we could incorporate into our suite for this?

@headius headius merged commit ccba557 into jruby:master Jun 24, 2013

1 check failed

default The Travis CI build could not complete due to an error
Details
@sclasen
Contributor
sclasen commented Jun 24, 2013

Let me see if I can isolate something

On Mon, Jun 24, 2013 at 3:42 PM, Charles Oliver Nutter <
notifications@github.com> wrote:

The fix passed all tests except one, so I'll go ahead with a merge. Do you
perhaps have a small test case we could incorporate into our suite for this?


Reply to this email directly or view it on GitHubhttps://github.com/jruby/jruby/pull/824#issuecomment-19941371
.

@sclasen
Contributor
sclasen commented Jun 24, 2013

@headius I have a test case which will blow up on 1.7.4 and work on the PR.

It needs to load a file, (ca_certs.pem extracted from mozilla). Where would I put such a file in the jruby codebase?

Also I assume I would put the spec in spec/ruby/library/openssl/x509 ?

LMK, I'll submit another PR

@headius
Member
headius commented Jun 24, 2013

@sclasen Yeah that would be good. I can coordinate getting it back into RubySpec upstream. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment