Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #823 #824

Merged
merged 1 commit into from Jun 24, 2013

Conversation

Projects
None yet
2 participants
@sclasen
Copy link
Contributor

sclasen commented Jun 24, 2013

Applied the fix from jruby/jruby-ossl#7 built jruby and used the build to run my broken test, which passed.

@headius

This comment has been minimized.

Copy link
Member

headius commented Jun 24, 2013

The fix passed all tests except one, so I'll go ahead with a merge. Do you perhaps have a small test case we could incorporate into our suite for this?

headius added a commit that referenced this pull request Jun 24, 2013

@headius headius merged commit ccba557 into jruby:master Jun 24, 2013

1 check failed

default The Travis CI build could not complete due to an error
Details
@sclasen

This comment has been minimized.

Copy link
Contributor Author

sclasen commented Jun 24, 2013

Let me see if I can isolate something

On Mon, Jun 24, 2013 at 3:42 PM, Charles Oliver Nutter <
notifications@github.com> wrote:

The fix passed all tests except one, so I'll go ahead with a merge. Do you
perhaps have a small test case we could incorporate into our suite for this?


Reply to this email directly or view it on GitHubhttps://github.com//pull/824#issuecomment-19941371
.

@sclasen

This comment has been minimized.

Copy link
Contributor Author

sclasen commented Jun 24, 2013

@headius I have a test case which will blow up on 1.7.4 and work on the PR.

It needs to load a file, (ca_certs.pem extracted from mozilla). Where would I put such a file in the jruby codebase?

Also I assume I would put the spec in spec/ruby/library/openssl/x509 ?

LMK, I'll submit another PR

@headius

This comment has been minimized.

Copy link
Member

headius commented Jun 24, 2013

@sclasen Yeah that would be good. I can coordinate getting it back into RubySpec upstream. Thank you!

@sclasen

This comment has been minimized.

Copy link
Contributor Author

sclasen commented Jun 25, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.