Komax codestyle override annotations #848

Closed
wants to merge 4 commits into
from

Conversation

Projects
None yet
2 participants
@komax
Member

komax commented Jul 2, 2013

PR on consistent code style (long lines) and addition of @override annotation.

komax added some commits Jun 27, 2013

removal of not required imports; add of @Override annotation for thes…
…e files;

comparing Strings by equals not on == in Java
addition of many @Override. Refactoring on some conditions using
String.equals(). Moved checks out of if conditions to extra variable, if it
used at least twice

Conflicts:
	src/org/jruby/compiler/ASTCompiler.java

@komax komax referenced this pull request Jul 2, 2013

Closed

Komax codereview #847

@enebo

This comment has been minimized.

Show comment
Hide comment
@enebo

enebo Jul 11, 2013

Member

Max, perhaps we will need to start with a smaller set than even this. Perhaps gist me over IM with changes and I can help pre-approve those changes.

Member

enebo commented Jul 11, 2013

Max, perhaps we will need to start with a smaller set than even this. Perhaps gist me over IM with changes and I can help pre-approve those changes.

@enebo enebo closed this Jul 11, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment