Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Komax codestyle override annotations #848

Closed
wants to merge 4 commits into from

Conversation

Projects
None yet
2 participants
@komax
Copy link
Member

komax commented Jul 2, 2013

PR on consistent code style (long lines) and addition of @override annotation.

Maximilian Konzack added some commits Jun 27, 2013

Maximilian Konzack
removal of not required imports; add of @override annotation for thes…
…e files;

comparing Strings by equals not on == in Java
Maximilian Konzack
addition of many @override. Refactoring on some conditions using
String.equals(). Moved checks out of if conditions to extra variable, if it
used at least twice

Conflicts:
	src/org/jruby/compiler/ASTCompiler.java

@komax komax referenced this pull request Jul 2, 2013

Closed

Komax codereview #847

@enebo

This comment has been minimized.

Copy link
Member

enebo commented Jul 11, 2013

Max, perhaps we will need to start with a smaller set than even this. Perhaps gist me over IM with changes and I can help pre-approve those changes.

@enebo enebo closed this Jul 11, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.