Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Maven Site reports #850

Closed
wants to merge 9 commits into from

Conversation

Projects
None yet
4 participants
@jendave
Copy link
Contributor

commented Jul 3, 2013

Added Maven Site reports including Javadoc generation, dependency/plugin analysis, test coverage, changelog and more.

headius and others added some commits Jul 3, 2013

Remove almost all binaries and switch to maven project.
In detail:

* Remove most jar and gem files from build_lib, since they will
  be sourced via maven.
* Remove nbproject and allow NetBeans to open us as a Maven
  project.
* Remove build.xml references to build_lib binaries
* Remove some ant build targets that are no longer used and/or
  will not work without build_lib present.
Remove remaining binaries from build_lib.
* bnd is now sourced from maven.
* bouncy-castle-java.rb moved under gems/bouncy-castle-java/lib.
* jruby-win32-ole gem will get sourced from maven.

Additional tweaks to get jar-dist working.
@BanzaiMan

This comment has been minimized.

Copy link
Member

commented Jul 3, 2013

Please rebase.

@BanzaiMan

This comment has been minimized.

Copy link
Member

commented Jul 3, 2013

For PRs, I advise you to use a topic branch, so that when you pull upstream changes into master, the PR won't get messed up.

@jendave jendave closed this Jul 4, 2013

@shartley

This comment has been minimized.

Copy link

commented on 28c6fbc Feb 10, 2014

For the Enum class Operation, the comment says for the OpFlags class "I cannot nest this class in an Enum class.";
I don't understand why not. Could OpFlags not just live at the bottom of the Enum or after the final value's semicolon?
From a personal taste point of view, I like to make these int value classes be interfaces instead: as it makes writing final static unnecessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.