Skip to content

Move Maven site reporting to parent pom. Fixed parent hierarchy. #864

Merged
merged 1 commit into from Jul 9, 2013

3 participants

@jendave
jendave commented Jul 9, 2013

Moved the Maven reporting to the parent pom so it can generate the proper reports for the entire project.

@headius headius merged commit d57a2ec into jruby:master Jul 9, 2013

1 check passed

Details default The Travis CI build passed
@headius
JRuby Team member
headius commented Jul 9, 2013

It looks good to me. Hopefully @mkristian can review it as well (merged).

@jendave jendave deleted the jendave:maven-reporting branch Jul 9, 2013
@mkristian
JRuby Team member

I just executed
$ mvn site
and it looks good until an error after
[INFO] There are 298415 checkstyle errors.

not sure if such a checkstyle is useful ;)

anyways once mvn site runs we need to think what to do with these reports. or at least get them onto CI to ensure they at least run. or . . .

@jendave
jendave commented Jul 9, 2013

I will examine the checkstyle errors. I can remove certain checks if they are superfluous. Worst case, I can remove the checkstyle altogether if you think it is not needed.

I had started looking into where to put the docs. There is a plugin to upload the site docs to Github, but there are so many docs that the plugin errors out. The SCM plugin could probably upload them as well, but that would be very slow. I'll see what I can do.

Thanks.

@mkristian
JRuby Team member

about the checkstyle - I do not know of style guide (which does not mean a lot) but if you can find a lenient style which produces only countable number of errors would be great - nobody will ever look through 230k errors ;)

I haven't really used site plugin for quite some time - so any help here is very appreciated.

@jendave
jendave commented Jul 9, 2013

No problem. I already created a more "lenient" style check set. I'll create a PR for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.