Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use <pluginManagement> in parent pom so that all plugins (and their versions) for the project can be centrally managed. #865

Merged
merged 3 commits into from Jul 9, 2013

Conversation

Projects
None yet
2 participants
@jendave
Copy link
Contributor

jendave commented Jul 9, 2013

All Maven plugins are now consistent (where necessary) throughout the project.

jendave added some commits Jul 9, 2013

Use <pluginManagement> in parent pom so that all plugins (and their v…
…ersions) for the project can be centrally managed. All Maven plugins are now consistent (where necessary) throughout the project.
Use <pluginManagement> in parent pom so that all plugins (and their v…
…ersions) for the project can be centrally managed. All Maven plugins are now consistent (where necessary) throughout the project.
@mkristian

This comment has been minimized.

Copy link
Member

mkristian commented Jul 9, 2013

that is great to have all the version in ONE place but I do miss the ./maven and ./docs hierarchy - would it be possible for you to include that as well.

@jendave

This comment has been minimized.

Copy link
Contributor Author

jendave commented Jul 9, 2013

I'll work on that for the next pull request. Thanks

@jendave

This comment has been minimized.

Copy link
Contributor Author

jendave commented Jul 9, 2013

Question - the ./maven and ./docs folder, they are run as separate builds from the main build. Should they be integrated into the main build. i.e. they should be a referenced in the parent pom?

@mkristian

This comment has been minimized.

Copy link
Member

mkristian commented Jul 9, 2013

the docs should run with -Pdocs (let the main build just run as well). the maven ones are more for distribution - I guess running them via -Pdist would do. I guess all my fiddling around with those profiles could just go away.

@jendave

This comment has been minimized.

Copy link
Contributor Author

jendave commented Jul 9, 2013

Great. I'll look at that. BTW, can you merge this PR?

mkristian added a commit that referenced this pull request Jul 9, 2013

Merge pull request #865 from jendave/plugin-management
Use <pluginManagement> in parent pom so that all plugins (and their versions) for the project can be centrally managed.

@mkristian mkristian merged commit eab1b17 into jruby:master Jul 9, 2013

1 check passed

default The Travis CI build passed
Details

@jendave jendave deleted the jendave:plugin-management branch Jul 9, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.