Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customize checkstyle to make it more lenient. #869

Merged
merged 3 commits into from Jul 10, 2013
Merged

Customize checkstyle to make it more lenient. #869

merged 3 commits into from Jul 10, 2013

Conversation

@jendave
Copy link
Contributor

@jendave jendave commented Jul 9, 2013

While there are still many checkstyle violations, most of them are formatting issues which I can handle fairly quickly.

@jendave
Copy link
Contributor Author

@jendave jendave commented Jul 10, 2013

Hi kristian. Can you look at this? Thanks.

@mkristian
Copy link
Member

@mkristian mkristian commented Jul 10, 2013

could you remove the .gitignore commit since I do have no overview of its impact. the iml files could go into your global gitignore. the lib/jruby-original.jar it feels it should not pop up. or are all those files generated by the mvn site execution ?

@jendave
Copy link
Contributor Author

@jendave jendave commented Jul 10, 2013

Thanks. I'll fix the commit.

@jendave
Copy link
Contributor Author

@jendave jendave commented Jul 10, 2013

I have reverted the change on .gitignore.

mkristian added a commit that referenced this pull request Jul 10, 2013
Customize checkstyle to make it more lenient.
@mkristian mkristian merged commit 7f5a592 into jruby:master Jul 10, 2013
1 check failed
1 check failed
@veganstraightedge
default The Travis CI build failed
Details
@jendave jendave deleted the jendave:checkstyle branch Jul 10, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants