Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade RSpec to latest version #883

Merged
merged 1 commit into from Jul 15, 2013

Conversation

Projects
None yet
3 participants
@prathamesh-sonpatki
Copy link
Contributor

prathamesh-sonpatki commented Jul 14, 2013

No description provided.

@BanzaiMan

This comment has been minimized.

Copy link
Member

BanzaiMan commented Jul 15, 2013

I am a bit wary of upgrading RSpec to 2.14.x, which I believe deprecated a whole lot of stuff, causing a lot of noise. 2.13.x should be OK. If the user wants 2.14.x, they should be able to do so.

@prathamesh-sonpatki

This comment has been minimized.

Copy link
Contributor Author

prathamesh-sonpatki commented Jul 15, 2013

@BanzaiMan I think its used only for JRuby development and build procedure. Users may use whatever version they want in their apps. Also i wanted to have clean travis run with Rspec 2.14.x as i have not run all specs locally. So that we will really know the impact of this change. But right now travis is failing for everything.

@enebo

This comment has been minimized.

Copy link
Member

enebo commented Jul 15, 2013

That's true. We do not ship rspec as part of our dist anymore. I don't
have a huge issue with upgrading since if we are internally using
deprecated stuff it would be better to know sooner than later, but is there
any other benefits to upgrading beyond staying current?

On Mon, Jul 15, 2013 at 2:32 AM, प्रथमेश notifications@github.com wrote:

@BanzaiMan https://github.com/BanzaiMan I think its used only for JRuby
development and build procedure. Users may use whatever version they want
in their apps. Also i wanted to have clean travis run with Rspec 2.14.x as
i have not run all specs locally. So that we will really know the impact of
this change. But right now travis is failing for everything.


Reply to this email directly or view it on GitHubhttps://github.com//pull/883#issuecomment-20955183
.

blog: http://blog.enebo.com twitter: tom_enebo
mail: tom.enebo@gmail.com

@prathamesh-sonpatki

This comment has been minimized.

Copy link
Contributor Author

prathamesh-sonpatki commented Jul 15, 2013

RSpec 2.14 will be last release in 2.x series so we will be better prepared for RSpec 3. Thats the main reason.

@enebo

This comment has been minimized.

Copy link
Member

enebo commented Jul 15, 2013

Ok so I am ok with internally updating rspec since only we use it for
development time but the JSON change should be decided separately since
that is a forward facing gem (isn't it)? Anyone have an opinion on this?

On Mon, Jul 15, 2013 at 10:49 AM, प्रथमेश notifications@github.com wrote:

RSpec 2.14 will be last release in 2.x series so we will be better
prepared for RSpec 3. Thats the main reason.


Reply to this email directly or view it on GitHubhttps://github.com//pull/883#issuecomment-20978943
.

blog: http://blog.enebo.com twitter: tom_enebo
mail: tom.enebo@gmail.com

@BanzaiMan

This comment has been minimized.

Copy link
Member

BanzaiMan commented Jul 15, 2013

@enebo If the specs pass, I'm fine with it. Either way, I think we should split this PR into two and discuss separately.

@prathamesh-sonpatki

This comment has been minimized.

Copy link
Contributor Author

prathamesh-sonpatki commented Jul 15, 2013

@BanzaiMan @enebo Updated this PR to only update RSpec

enebo added a commit that referenced this pull request Jul 15, 2013

Merge pull request #883 from prathamesh-sonpatki/upgrade-gems
Upgrade RSpec to latest version

@enebo enebo merged commit 340d931 into jruby:master Jul 15, 2013

1 check passed

default The Travis CI build passed
Details

@prathamesh-sonpatki prathamesh-sonpatki deleted the prathamesh-sonpatki:upgrade-gems branch Jul 15, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.