Upgrade RSpec to latest version #883

Merged
merged 1 commit into from Jul 15, 2013

Projects

None yet

3 participants

@prathamesh-sonpatki

No description provided.

@BanzaiMan
JRuby Team member

I am a bit wary of upgrading RSpec to 2.14.x, which I believe deprecated a whole lot of stuff, causing a lot of noise. 2.13.x should be OK. If the user wants 2.14.x, they should be able to do so.

@prathamesh-sonpatki

@BanzaiMan I think its used only for JRuby development and build procedure. Users may use whatever version they want in their apps. Also i wanted to have clean travis run with Rspec 2.14.x as i have not run all specs locally. So that we will really know the impact of this change. But right now travis is failing for everything.

@enebo
JRuby Team member
@prathamesh-sonpatki

RSpec 2.14 will be last release in 2.x series so we will be better prepared for RSpec 3. Thats the main reason.

@enebo
JRuby Team member
@BanzaiMan
JRuby Team member

@enebo If the specs pass, I'm fine with it. Either way, I think we should split this PR into two and discuss separately.

@prathamesh-sonpatki

@BanzaiMan @enebo Updated this PR to only update RSpec

@enebo enebo merged commit 340d931 into jruby:master Jul 15, 2013

1 check passed

Details default The Travis CI build passed
@prathamesh-sonpatki prathamesh-sonpatki deleted the prathamesh-sonpatki:upgrade-gems branch Jul 15, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment