Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More arg-handling improvements for Enumerables #928

Merged
merged 1 commit into from Aug 28, 2013

Conversation

Projects
None yet
2 participants
@dmarcotte
Copy link
Contributor

dmarcotte commented Jul 30, 2013

Here's the first follow-up (of probably a few) to #898, getting things even closer to full compatibility for Enumerable.

This makes Enumerable#all, #none, #one, and #find_index behave to
spec in the case of #each yielding multiple values (also untags #zip_tags since it's passing).

Note that this fix smells a touch too localized at the moment (what's so special about CallBlock's yield that we prep the args there? Isn't it likely that there's other places that need the same treatment?), but as I fix the rest of the Enumerable arg issues, I'm hoping that a good, holistic approach will reveal itself.

(Side note: I see Travis is red at the moment, but you can see a clean run on this branch here)

Some yield arg-handling improvements
Make Enumerable#all, #none, #one, and #find_index behave to spec in the
case of #each yielding multiple values (also remove zip_tags.txt while
we're in there since it's passing)

enebo added a commit that referenced this pull request Aug 28, 2013

Merge pull request #928 from dmarcotte/yield-args
More arg-handling improvements for Enumerables

@enebo enebo merged commit fcfa4e7 into jruby:master Aug 28, 2013

1 check failed

default The Travis CI build could not complete due to an error
Details
@dmarcotte

This comment has been minimized.

Copy link
Contributor Author

dmarcotte commented Oct 21, 2013

@enebo: fyi I just sent #1143 addressing the "too localized" concern here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.