Skip to content

More arg-handling improvements for Enumerables #928

Merged
merged 1 commit into from Aug 28, 2013

2 participants

@dmarcotte

Here's the first follow-up (of probably a few) to #898, getting things even closer to full compatibility for Enumerable.

This makes Enumerable#all, #none, #one, and #find_index behave to
spec in the case of #each yielding multiple values (also untags #zip_tags since it's passing).

Note that this fix smells a touch too localized at the moment (what's so special about CallBlock's yield that we prep the args there? Isn't it likely that there's other places that need the same treatment?), but as I fix the rest of the Enumerable arg issues, I'm hoping that a good, holistic approach will reveal itself.

(Side note: I see Travis is red at the moment, but you can see a clean run on this branch here)

@dmarcotte dmarcotte Some yield arg-handling improvements
Make Enumerable#all, #none, #one, and #find_index behave to spec in the
case of #each yielding multiple values (also remove zip_tags.txt while
we're in there since it's passing)
91c11f0
@enebo enebo merged commit fcfa4e7 into jruby:master Aug 28, 2013

1 check failed

Details default The Travis CI build could not complete due to an error
@dmarcotte

@enebo: fyi I just sent #1143 addressing the "too localized" concern here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.