use expect instead of should in rspec #966

Merged
merged 1 commit into from Aug 23, 2013

Projects

None yet

3 participants

@rajcybage
Contributor

As we are using rspec new version we can use then expect in all our rspec test cases.

As for better rspec http://betterspecs.org/#expect.

If it is acceptable then I will proceed to change others

Thanks

@rajcybage
Contributor
@BanzaiMan BanzaiMan was assigned Aug 21, 2013
@BanzaiMan BanzaiMan commented on an outdated diff Aug 21, 2013
spec/java_integration/addons/throwable_spec.rb
end
it "does not prevent catch/throw from working" do
- lambda do
+ expect do
@BanzaiMan
BanzaiMan Aug 21, 2013 Member

Indentation seems off here.

@BanzaiMan
Member

The commit subject should be fixed.

@rajcybage
Contributor

Done

Thank you @BanzaiMan

@jrubyci jrubyci merged commit 76b73a8 into jruby:master Aug 23, 2013

1 check passed

default The Travis CI build passed
Details
@rajcybage rajcybage deleted the unknown repository branch Aug 23, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment