Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use expect instead of should in rspec #966

Merged
merged 1 commit into from Aug 23, 2013

Conversation

Projects
None yet
3 participants
@rajcybage
Copy link
Contributor

rajcybage commented Aug 21, 2013

As we are using rspec new version we can use then expect in all our rspec test cases.

As for better rspec http://betterspecs.org/#expect.

If it is acceptable then I will proceed to change others

Thanks

@rajcybage

This comment has been minimized.

Copy link
Contributor Author

rajcybage commented Aug 21, 2013

@ghost ghost assigned BanzaiMan Aug 21, 2013

end

it "does not prevent catch/throw from working" do
lambda do
expect do

This comment has been minimized.

Copy link
@BanzaiMan

BanzaiMan Aug 21, 2013

Member

Indentation seems off here.

@BanzaiMan

This comment has been minimized.

Copy link
Member

BanzaiMan commented Aug 21, 2013

The commit subject should be fixed.

@rajcybage

This comment has been minimized.

Copy link
Contributor Author

rajcybage commented Aug 22, 2013

Done

Thank you @BanzaiMan

BanzaiMan added a commit that referenced this pull request Aug 23, 2013

Merge pull request #966 from rajcybage/rspec_fix
use expect instead of should in rspec

@jrubyci jrubyci merged commit 76b73a8 into jruby:master Aug 23, 2013

1 check passed

default The Travis CI build passed
Details

@rajcybage rajcybage deleted the rajcybage:rspec_fix branch Aug 23, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.