Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to newer dependencies? #2

Closed
utkarsh2102 opened this issue Jan 5, 2021 · 6 comments · Fixed by #3
Closed

Bump to newer dependencies? #2

utkarsh2102 opened this issue Jan 5, 2021 · 6 comments · Fixed by #3

Comments

@utkarsh2102
Copy link
Contributor

Hello,

spec.add_development_dependency "bundler", "~> 1.15"
spec.add_development_dependency "rake", "~> 10.0"

These versions are a bit too old. Do you think we can move to bundler 2.x and rake 13.x?
Besides, Ruby 3.0 is out. While at it, can we make sure it is ready for that as well?

@headius
Copy link
Member

headius commented Jan 5, 2021

I see no reason not to update development depedencies. As for Ruby 3.0, this gem is specific to JRuby (uses our Java integration layer) so that won't be relevant until JRuby supports 3.0 features (some time in 2021).

@utkarsh2102
Copy link
Contributor Author

Aah, that makes sense. Do you want me to open a PR for bumping the dependendies? Could you maybe do a patch release post that?

@headius
Copy link
Member

headius commented Jan 5, 2021

@utkarsh2102 Sure, post a PR! We can spin a release but this change won't have any visible impact since these are development dependencies and are only used during local development of the rake-ant code.

@utkarsh2102
Copy link
Contributor Author

We can spin a release but this change won't have any visible impact since these are development dependencies and are only used during local development of the rake-ant code.

That's right. But I ask for new release because we're updating the version of jruby in Debian and for that we need to package rake-ant to build. So whilst building rake-ant in Debian, it'd be great if we have the newer versions of rake and bundler! 😄

@utkarsh2102
Copy link
Contributor Author

Sure, post a PR!

Done via #3! 🎉

@headius headius closed this as completed in #3 Jan 7, 2021
@headius
Copy link
Member

headius commented Jan 7, 2021

@utkarsh2102 Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants