Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop git from gemspec? #4

Closed
utkarsh2102 opened this issue Jan 6, 2021 · 1 comment · Fixed by #5
Closed

Drop git from gemspec? #4

utkarsh2102 opened this issue Jan 6, 2021 · 1 comment · Fixed by #5

Comments

@utkarsh2102
Copy link
Contributor

Hello,

spec.files = `git ls-files -z`.split("\x0").reject do |f|
f.match(%r{^(test|spec|features)/})
end

Using git in gemspec is somewhat problematic and it's best if avoided.
Here's the more verbose rationale: https://docs.rubocop.org/rubocop-packaging/cops_packaging.html#gemspec-git-rationale

If you agree to drop git from gemspec and use Dir or Dir.glob, I'd be happy to raise a PR! Let me know what you think?

@headius
Copy link
Member

headius commented Jan 7, 2021

I think for this library it would be fine to use Dir instead of the call to git. Go for it!

utkarsh2102 added a commit to utkarsh2102/rake-ant that referenced this issue Jan 15, 2021
Closes: jruby#4

Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants