We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hello,
rake-ant/rake-ant.gemspec
Lines 17 to 19 in 317930b
Using git in gemspec is somewhat problematic and it's best if avoided. Here's the more verbose rationale: https://docs.rubocop.org/rubocop-packaging/cops_packaging.html#gemspec-git-rationale
If you agree to drop git from gemspec and use Dir or Dir.glob, I'd be happy to raise a PR! Let me know what you think?
git
Dir
Dir.glob
The text was updated successfully, but these errors were encountered:
I think for this library it would be fine to use Dir instead of the call to git. Go for it!
Sorry, something went wrong.
Drop git ls-files in gemspec
git ls-files
e7dec73
Closes: jruby#4 Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
Successfully merging a pull request may close this issue.
Hello,
rake-ant/rake-ant.gemspec
Lines 17 to 19 in 317930b
Using git in gemspec is somewhat problematic and it's best if avoided.
Here's the more verbose rationale: https://docs.rubocop.org/rubocop-packaging/cops_packaging.html#gemspec-git-rationale
If you agree to drop
gitfrom gemspec and useDirorDir.glob, I'd be happy to raise a PR! Let me know what you think?The text was updated successfully, but these errors were encountered: