styles: Switch AppTheme to MaterialComponents#114
Merged
jruesga merged 1 commit intojruesga:masterfrom May 17, 2020
ix5:theme-material-aboutpage
Merged
styles: Switch AppTheme to MaterialComponents#114jruesga merged 1 commit intojruesga:masterfrom ix5:theme-material-aboutpage
jruesga merged 1 commit intojruesga:masterfrom
ix5:theme-material-aboutpage
Conversation
The dependency "AboutLibraries" contains a layout named listheader_opensource.xml, which contains references to com.google.android.material.button.MaterialButton. That one in turn requires the base app theme to be a descendant of `Theme.MaterialComponents`: ``` android.view.InflateException: Binary XML file line #48 in \ com.ruesga.rview.debug:layout/listheader_opensource: \ Binary XML file line #48 in com.ruesga.rview.debug:layout/listheader_opensource: \ Error inflating class com.google.android.material.button.MaterialButton Caused by: java.lang.IllegalArgumentException: \ The style on this component requires your app theme to be \ Theme.MaterialComponents (or a descendant). ```
Owner
|
@ix5 it's ok to me. I will merge this one. Thanks for the patch. |
ix5
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a crash when opening the "About" page.
The dependency "AboutLibraries" contains a layout named listheader_opensource.xml, which contains references to com.google.android.material.button.MaterialButton.
That one in turn requires the base app theme to be a descendant of
Theme.MaterialComponents:@jruesga This is quite ugly, do you think only styling the AboutLibraries fragment could work instead? They suggest using something akin to defining a
CustomAboutLibrariesStylewith `parent="Theme.MaterialComponents.Light.NoActionBar", see the READMEBtw, still haven't forgotten about the F-Droid submission, got a lot on my plate though ;)