New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switches linting to eslint & removes jshint and jscs #451

Merged
merged 1 commit into from Jul 1, 2018

Conversation

Projects
None yet
2 participants
@realityking
Contributor

realityking commented Jun 16, 2018

No description provided.

@FagnerMartinsBrack

This comment has been minimized.

Show comment
Hide comment
@FagnerMartinsBrack

FagnerMartinsBrack Jun 20, 2018

Member

Good stuff. What's the main reason for the change, though?

Member

FagnerMartinsBrack commented Jun 20, 2018

Good stuff. What's the main reason for the change, though?

@realityking

This comment has been minimized.

Show comment
Hide comment
@realityking

realityking Jun 20, 2018

Contributor

Sorry, should have given more context. jscs is unmaintained - the repo is archived - and this merges two configs into one, making things a bit easier to grasp.

Contributor

realityking commented Jun 20, 2018

Sorry, should have given more context. jscs is unmaintained - the repo is archived - and this merges two configs into one, making things a bit easier to grasp.

@FagnerMartinsBrack

This comment has been minimized.

Show comment
Hide comment
@FagnerMartinsBrack

FagnerMartinsBrack Jun 21, 2018

Member

I see this looks good then assuming that the behavior remains unchanged.

Member

FagnerMartinsBrack commented Jun 21, 2018

I see this looks good then assuming that the behavior remains unchanged.

Show outdated Hide outdated package.json Outdated
Switches linting to eslint
Removes jshint and jscs
@realityking

This comment has been minimized.

Show comment
Hide comment
@realityking

realityking Jul 1, 2018

Contributor

Behaviour should be the same, I used https://github.com/brenolf/polyjuice for the conversion + couple of manual fixes for the cases it didn't cover.

Contributor

realityking commented Jul 1, 2018

Behaviour should be the same, I used https://github.com/brenolf/polyjuice for the conversion + couple of manual fixes for the cases it didn't cover.

@FagnerMartinsBrack FagnerMartinsBrack merged commit 69f802b into js-cookie:master Jul 1, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@realityking realityking deleted the realityking:eslint branch Jul 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment