Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reactour.js.org #2194

Merged
merged 1 commit into from Aug 3, 2018
Merged

reactour.js.org #2194

merged 1 commit into from Aug 3, 2018

Conversation

elrumordelaluz
Copy link
Contributor

@indus indus changed the title Add reactour reactour.js.org Aug 2, 2018
@indus indus added add This PR/issue is regarding adding a new subdomain user This PR/issue is regarding a target on a GitHub user account project This PR has a target of a project on an organisation or user account labels Aug 2, 2018
@indus
Copy link
Member

indus commented Aug 2, 2018

When you are using a master branch in a project repo for GitHub pages you need to make adjustments in the repo settings: https://help.github.com/articles/configuring-a-publishing-source-for-github-pages
I'll merge after we have "contact".

@elrumordelaluz
Copy link
Contributor Author

Hi @indus I have set my repo to use /docs folder.

Is there another change I need to apply?

@indus
Copy link
Member

indus commented Aug 2, 2018

Looks still misconfigured. maybe you have to move the CNAME manually from the root of the branch to the docs folder?!?

@indus indus added the invalid label Aug 2, 2018
@elrumordelaluz
Copy link
Contributor Author

maybe you have to move the CNAME manually from the root of the branch to the docs folder?!?

thanks you @indus! that was the issue, file moved

@indus indus removed the invalid label Aug 3, 2018
@indus
Copy link
Member

indus commented Aug 3, 2018

Welcome https://reactour.js.org

@indus indus merged commit 46ed856 into js-org:master Aug 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add This PR/issue is regarding adding a new subdomain project This PR has a target of a project on an organisation or user account user This PR/issue is regarding a target on a GitHub user account
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants