New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redux-starter-kit.js.org #2571

Merged
merged 1 commit into from Dec 6, 2018

Conversation

Projects
None yet
3 participants
@markerikson
Contributor

markerikson commented Dec 2, 2018

Currently working on setting up docs publishing for redux-starter-kit , per reduxjs/redux-starter-kit#48 . I've added a placeholder docs page with an export of the current content, which will be replaced once we get a docs build set up.

@MattIPv4

Commit valid, site has content *

* based on https://redux-starter-kit-docs.netlify.com/

I trust it is ready to work with the js.org subdomain requested :)

@MattIPv4 MattIPv4 changed the title from Add redux-starter-kit to redux-starter-kit.js.org Dec 3, 2018

@markerikson

This comment has been minimized.

Contributor

markerikson commented Dec 3, 2018

Yep, once this is merged I'll just add the domain name to the Netlify site config.

@MattIPv4

This comment has been minimized.

Collaborator

MattIPv4 commented Dec 3, 2018

@markerikson I imagine @indus will want it working before this is fully merged. I'm sure he'll explain better when he pops over to here.

@indus indus added the invalid label Dec 3, 2018

@indus

This comment has been minimized.

Member

indus commented Dec 3, 2018

As stated in the readme I'm not accepting requests for pages without content. I´m going to close this but feel free to open a new PR when your page is ready for the public.

@indus indus closed this Dec 3, 2018

@indus

This comment has been minimized.

Member

indus commented Dec 3, 2018

Oh - I 've just seen this link: https://redux-starter-kit-docs.netlify.com/
I've already added your requested subdomain to JS.ORGs zonefile. But you have to make the site work.
I'll merge after we have "contact".

@indus indus reopened this Dec 3, 2018

@markerikson

This comment has been minimized.

Contributor

markerikson commented Dec 3, 2018

Yeah, I've got a temporary static HTML page there that I hand-generated based on the library's current README, but it's representative of the actual content. We're working on setting up an actual docs site build right now, and I'll switch out the placeholder page once the docs build is set up.

@indus

This comment has been minimized.

Member

indus commented Dec 4, 2018

I'll wait for a week. Otherwise you will have to make a new PR.

@indus indus added awaiting response and removed invalid labels Dec 4, 2018

@markerikson

This comment has been minimized.

Contributor

markerikson commented Dec 6, 2018

Done, the new docs site is live:

https://redux-starter-kit-docs.netlify.com/

@markerikson

This comment has been minimized.

Contributor

markerikson commented Dec 6, 2018

Added https://redux-starter-kit.js.org to my Netlify config, and looks like we're live!

@indus indus removed the awaiting response label Dec 6, 2018

@indus

This comment has been minimized.

Member

indus commented Dec 6, 2018

@indus indus merged commit 3e0fa7e into js-org:master Dec 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment