New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

atomic-layout.js.org #2659

Merged
merged 1 commit into from Jan 2, 2019

Conversation

Projects
None yet
3 participants
@kettanaito
Copy link
Contributor

kettanaito commented Jan 1, 2019

@MattIPv4
Copy link
Collaborator

MattIPv4 left a comment

Hi there!

Before we can accept your domain request, you need to create a file named CNAME in the root of your github pages site (this may not be the root of your repository). This file should contain a single line with the full js.org domain you are requesting, in this instance atomic-layout.js.org.

@MattIPv4 MattIPv4 changed the title Adds "atomic-layout" atomic-layout.js.org Jan 1, 2019

@kettanaito

This comment has been minimized.

Copy link
Contributor

kettanaito commented Jan 1, 2019

Thanks for the check. I've added CNAME to the root of the docs. Should be there now.

@MattIPv4
Copy link
Collaborator

MattIPv4 left a comment

Commit valid, CNAME present, site appears to have content*

* based off https://github.com/kettanaito/atomic-layout-docs/tree/master/docs

@MattIPv4 MattIPv4 removed the awaiting CNAME label Jan 1, 2019

@indus

This comment has been minimized.

Copy link
Member

indus commented Jan 1, 2019

I've already added your requested subdomain to JS.ORGs zonefile. But you have to change some paths to make it work.
I'll merge after I had a look at your page.

@kettanaito

This comment has been minimized.

Copy link
Contributor

kettanaito commented Jan 1, 2019

@indus Thank you!

I've adjusted the config to reference resources from the root of the website. However, I can still see an issue that some resources that are in the repo return 404 when requested on the website... I'm not sure why that happens yet.

@indus

This comment has been minimized.

Copy link
Member

indus commented Jan 2, 2019

@indus indus merged commit 2e6b05e into js-org:master Jan 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment