New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benjick.js.org #2778

Merged
merged 1 commit into from Feb 12, 2019

Conversation

Projects
None yet
3 participants
@benjick
Copy link
Contributor

benjick commented Feb 11, 2019

Added my Github user

Update cnames_active.js
Added my Github user
@MattIPv4
Copy link
Collaborator

MattIPv4 left a comment

Hi there!

The site you have linked to for your js.org domain request returns a 404: http://benjick.github.io/
Please fix this before we can process your js.org domain request. 🛠

@MattIPv4 MattIPv4 changed the title Update cnames_active.js benjick.js.org Feb 11, 2019

@benjick

This comment has been minimized.

Copy link
Contributor Author

benjick commented Feb 12, 2019

Sorry, I misunderstood the "No Content". Is this acceptable for now? http://benjick.github.io/

@MattIPv4

This comment has been minimized.

Copy link
Collaborator

MattIPv4 commented Feb 12, 2019

@benjick It appears to now be heading to a generic, default react app site? I would no consider this reasonable content.

@benjick

This comment has been minimized.

Copy link
Contributor Author

benjick commented Feb 12, 2019

It's the demo page for my library called react-doc-title, linked from the github readme. I wanna use this domain for all my packages demos going forward

@MattIPv4

This comment has been minimized.

Copy link
Collaborator

MattIPv4 commented Feb 12, 2019

@benjick Right okay, fair enough. You need to setup the CNAME file for the js.org subdomain to work please.

@benjick

This comment has been minimized.

Copy link
Contributor Author

benjick commented Feb 12, 2019

Done! And thank you!

@indus

This comment has been minimized.

Copy link
Member

indus commented Feb 12, 2019

Welcome https://benjick.js.org

@indus indus merged commit e7d73a5 into js-org:master Feb 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment