Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

abbyz.js.org #2862

Merged
merged 3 commits into from Mar 12, 2019

Conversation

Projects
None yet
3 participants
@Abbyzhoum
Copy link

Abbyzhoum commented Mar 7, 2019

@MattIPv4 MattIPv4 changed the title add a new js.org abbyz.js.org Mar 7, 2019

@MattIPv4
Copy link
Collaborator

MattIPv4 left a comment

Hi there!

The site you have linked to for your js.org domain request returns a 404: https://abbyzhoum.github.io/Abbyzhoum
Please fix this before we can process your js.org domain request. 🛠

@MattIPv4 MattIPv4 added add 404 labels Mar 7, 2019

@Abbyzhoum

This comment has been minimized.

Copy link
Author

Abbyzhoum commented Mar 8, 2019

Please try Abbyzhoum.github.io

@Abbyzhoum

This comment has been minimized.

Copy link
Author

Abbyzhoum commented Mar 8, 2019

I fixed it, please try this site https://abbyzhoum.github.io

@MattIPv4

This comment has been minimized.

Copy link
Collaborator

MattIPv4 commented Mar 8, 2019

@Abbyzhoum If the target is intended to be abbyzhoum.github.io, please update your PR to this.
I will then continue to review it.

@Abbyzhoum

This comment has been minimized.

Copy link
Author

Abbyzhoum commented Mar 8, 2019

I updated my PR to this ,you can check !

@MattIPv4
Copy link
Collaborator

MattIPv4 left a comment

Hi there!

Before we can accept your domain request, you need to create a file named CNAME in the root of your github pages site (this may not be the root of your repository). 📝
This file should contain a single line with the full js.org domain you are requesting, in this instance abbyz.js.org.

@MattIPv4 MattIPv4 added user awaiting CNAME and removed 404 labels Mar 8, 2019

@indus

This comment has been minimized.

Copy link
Member

indus commented Mar 11, 2019

@Abbyzhoum If you are not adding the CNAME to your repository your subdomain won't work and I will have to close your PR.

@Abbyzhoum

This comment has been minimized.

Copy link
Author

Abbyzhoum commented Mar 12, 2019

I added the CNAME in my repository .please check!

@MattIPv4
Copy link
Collaborator

MattIPv4 left a comment

Commit valid, CNAME present, site appears to have content *

* based off https://github.com/Abbyzhoum/Abbyzhoum.github.io

@indus

This comment has been minimized.

Copy link
Member

indus commented Mar 12, 2019

I'm sorry, but your PR can't be processed right now. The number of subdomains added to JS.ORGs zonefile hit the quota of cloudflare: #2873

@indus indus added on hold and removed on hold labels Mar 12, 2019

@indus

This comment has been minimized.

Copy link
Member

indus commented Mar 12, 2019

@indus indus merged commit 98b7a99 into js-org:master Mar 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.