Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lcookie.js.org #2875

Merged
merged 1 commit into from Mar 13, 2019

Conversation

Projects
None yet
3 participants
@hifocus
Copy link
Contributor

hifocus commented Mar 13, 2019

Hi there :)

My friend @LF112 is currently developing a cookie banner component through https://github.com/LF112/lcookie/, and I get involved in this project and working on his documentations (Please see here: https://github.com/LF112/lcookie/graphs/contributors)

The page had got reasonable contents and @LF112 already set GitHub Pages custom domain to lcookie.js.org (so you won't get a direct preview while browsing http://lf112.github.io/lcookie, please use htmlpreview.github.io: https://htmlpreview.github.io/?https://github.com/LF112/lcookie/blob/gh-pages/index.html)

Hope this can be aprroved! Thank you and have a nice day in Germany!

@MattIPv4
Copy link
Collaborator

MattIPv4 left a comment

Commit valid, CNAME present, site appears to have content *

* based off https://github.com/LF112/lcookie/tree/gh-pages

@MattIPv4 MattIPv4 changed the title Add lcookie.js.org lcookie.js.org Mar 13, 2019

@indus

This comment has been minimized.

Copy link
Member

indus commented Mar 13, 2019

@indus indus merged commit 0f21f8f into js-org:master Mar 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.