Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

charge.js.org #2880

Merged
merged 1 commit into from Mar 14, 2019

Conversation

Projects
None yet
3 participants
@brandonweiss
Copy link
Contributor

brandonweiss commented Mar 14, 2019

I’d like to use this subdomain for the docs for Charge. Thanks!

P.S. There is content but it looks broken and unstyled because GitHub uses a sub-directory (brandoweiss.github.io/charge) but the stylesheet and image links use absolute URLs (without a domain/hostname). As soon as it’s using a custom sub-domain all the links will work correctly!

charge.js.org
[x] There is reasonable content on the page (see: No Content)
[x] I have read and accepted the Terms and Conditions

I’d like to use this subdomain for the docs for [Charge](https://github.com/brandonweiss/charge). Thanks!

P.S. There is content but it looks broken and unstyled because GitHub uses a sub-directory (github.com/brandonweiss/charge) but the stylesheet and image links use absolute URLs (without a domain/hostname). As soon as it’s using a custom sub-domain without all the links will work correctly!
@MattIPv4
Copy link
Collaborator

MattIPv4 left a comment

Hi there!

Before we can accept your domain request, you need to create a file named CNAME in the root of your github pages site (this may not be the root of your repository). 📝
This file should contain a single line with the full js.org domain you are requesting, in this instance charge.js.org.

@brandonweiss

This comment has been minimized.

Copy link
Contributor Author

brandonweiss commented Mar 14, 2019

That’s weird, I do have one… I’m not sure what happened. I just checked and it’s there.

https://github.com/brandonweiss/charge/blob/gh-pages/CNAME

@MattIPv4

This comment has been minimized.

Copy link
Collaborator

MattIPv4 commented Mar 14, 2019

@brandonweiss https://brandonweiss.github.io/charge/ isn't redirecting to the js.org domain in the CNAME file as expected. Please check your GitHub pages settings to ensure it has detected the custom domain correctly.

@brandonweiss

This comment has been minimized.

Copy link
Contributor Author

brandonweiss commented Mar 14, 2019

@MattIPv4 Oh, sorry! I wasn’t exactly sure what order to do that in. I wasn’t sure how you’d verify the presence of content if I added the custom domain first.

I just added the custom domain in the project settings!

@MattIPv4
Copy link
Collaborator

MattIPv4 left a comment

Commit valid, CNAME present, site appears to have content *

* based off https://github.com/brandonweiss/charge/tree/gh-pages

@indus

This comment has been minimized.

Copy link
Member

indus commented Mar 14, 2019

@indus indus merged commit 3023596 into js-org:master Mar 14, 2019

@brandonweiss

This comment has been minimized.

Copy link
Contributor Author

brandonweiss commented Mar 14, 2019

@indus Thanks! ❤️

@brandonweiss brandonweiss referenced this pull request Mar 15, 2019

Merged

charge.js.org #2882

2 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.