Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

showroom.js.org #2925

Merged
merged 1 commit into from Apr 4, 2019

Conversation

Projects
None yet
3 participants
@eavichay
Copy link
Contributor

commented Apr 4, 2019

@MattIPv4 MattIPv4 changed the title Adding showroom.js project showroom.js.org Apr 4, 2019

@MattIPv4
Copy link
Collaborator

left a comment

Commit valid, site has content.

I trust that heroku is configured ready to work with the requested js.org subdomain.

@eavichay

This comment has been minimized.

Copy link
Contributor Author

commented Apr 4, 2019

@MattIPv4 Thanks 👍

@indus

This comment has been minimized.

Copy link
Member

commented Apr 4, 2019

@eavichay https://showroom.js.org/ gives me a heroku 404(?): "There's nothing here, yet."
As stated in the readme I'm not accepting requests for pages without content.

@eavichay

This comment has been minimized.

Copy link
Contributor Author

commented Apr 4, 2019

@indus Fixed.

@indus

This comment has been minimized.

Copy link
Member

commented Apr 4, 2019

@indus indus merged commit bea06ff into js-org:master Apr 4, 2019

@eavichay eavichay deleted the eavichay:patch-2 branch Apr 4, 2019

@eavichay

This comment has been minimized.

Copy link
Contributor Author

commented Apr 4, 2019

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.