Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

agentnpm.js.org #2953

Merged
merged 3 commits into from Apr 11, 2019

Conversation

Projects
None yet
4 participants
@MeetPing
Copy link
Contributor

commented Apr 11, 2019

@MattIPv4
Copy link
Collaborator

left a comment

Hi there!

Your requested js.org subdomain must be inserted in alphabetical order in the cnames_active.js file before we can process your request. Please fix this. 🔤

@MattIPv4 MattIPv4 changed the title Update cnames_active.js agentnpm.js.org Apr 11, 2019

@MeetPing

This comment has been minimized.

Copy link
Contributor Author

commented Apr 11, 2019

did you do it? in the alpha betical order since i really don know how to use the Pull Request

@SiddharthBose-Codeware

This comment has been minimized.

Copy link
Contributor

commented Apr 11, 2019

Yes. Just obvious. See the entries.

@MeetPing

This comment has been minimized.

Copy link
Contributor Author

commented Apr 11, 2019

i may or may not have just made it myself lol

@MeetPing

This comment has been minimized.

Copy link
Contributor Author

commented Apr 11, 2019

i will now wait until this agentnpm.js.org gets agreed

@MattIPv4
Copy link
Collaborator

left a comment

Commit valid, CNAME present, site appears to have content *

* based off https://github.com/MeetPing/agentnpm

@MattIPv4 MattIPv4 removed the invalid label Apr 11, 2019

@MeetPing

This comment has been minimized.

Copy link
Contributor Author

commented Apr 11, 2019

YAY

@SiddharthBose-Codeware

This comment has been minimized.

Copy link
Contributor

commented Apr 11, 2019

I wish my PR would also get merged so smoothly. Glad to help.

@MeetPing

This comment has been minimized.

Copy link
Contributor Author

commented Apr 11, 2019

@SiddharthBose-Codeware PR? whats a PR?
Sorry i dont know some english words im finnish and yet my english is magnificent

@SiddharthBose-Codeware

This comment has been minimized.

Copy link
Contributor

commented Apr 11, 2019

PR stands for Pull Request.

@SiddharthBose-Codeware

This comment has been minimized.

Copy link
Contributor

commented Apr 11, 2019

@MeetPing you should not wait because I guess that @indus will merge the commit, so it will take time.

@indus

This comment has been minimized.

Copy link
Member

commented Apr 11, 2019

@indus indus merged commit 823acec into js-org:master Apr 11, 2019

@MeetPing

This comment has been minimized.

Copy link
Contributor Author

commented Apr 11, 2019

YAY

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.