Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rengular.js.org #3007

Merged
merged 1 commit into from May 5, 2019

Conversation

Projects
None yet
3 participants
@chigix
Copy link
Contributor

commented May 5, 2019

@MattIPv4
Copy link
Collaborator

left a comment

Hi there!

Before we can accept your domain request, you need to create a file named CNAME in the root of your github pages site (this may not be the root of your repository). 📝
This file should contain a single line with the full js.org domain you are requesting, in this instance rengular.js.org.

@MattIPv4 MattIPv4 changed the title Add rengular.js rengular.js.org May 5, 2019

@chigix

This comment has been minimized.

Copy link
Contributor Author

commented May 5, 2019

@MattIPv4 Hi, thanks for checking and feedback. I've tried to append the CNAME named file under the root of the GitHub page branch. However I find it would make my current page inaccessible, for which I commented that file as CNAME.bak currently. So should I revert this CNAME.bak file to be CNAME ?

@indus

This comment has been minimized.

Copy link
Member

commented May 5, 2019

@chigix Yes please revert it to "CNAME".
I've already added your requested subdomain to JS.ORGs zonefile.
I'll merge after we have "contact".

@chigix

This comment has been minimized.

Copy link
Contributor Author

commented May 5, 2019

@MattIPv4 @indus I've fixed GitHub page branch and confirmed that my page works under js.org domain.

@indus indus removed the awaiting CNAME label May 5, 2019

@indus

This comment has been minimized.

Copy link
Member

commented May 5, 2019

@indus indus merged commit 2bdd4e4 into js-org:master May 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.