Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ngxcebu.js.org #3025

Merged
merged 4 commits into from May 11, 2019

Conversation

Projects
None yet
3 participants
@microinclude
Copy link
Contributor

commented May 9, 2019

@MattIPv4
Copy link
Collaborator

left a comment

Hi there,

In the changes, you have requested microinclude.js.org, however, in the title you are requesting ngxcebu.js.org. Neither of these align with the project name, angular-cebu.

Please fix this.

See https://github.com/js-org/js.org/wiki/Subdomain-Determination

@microinclude
Copy link
Contributor Author

left a comment

edited :) Thank you and sorry, I haven't read the top-most part of the file :) Regards,

MattIPv4 and others added some commits May 9, 2019

@MattIPv4
Copy link
Collaborator

left a comment

Hiya,

Currently, you have
Commit valid, CNAME present, site appears to have content *

* based off https://github.com/angular-cebu/angular-cebu.github.io

@indus

This comment has been minimized.

Copy link
Member

commented May 10, 2019

I've already added your requested subdomain to JS.ORGs zonefile. But you have to revert the deletion of CNAME (angular-cebu/angular-cebu.github.io@830649c) to make it work.
I'll merge after we have "contact".

@microinclude

This comment has been minimized.

Copy link
Contributor Author

commented May 11, 2019

hi indus, sorry had to revert it back to the github io domain yesterday for demo purposes but reverted it back now :D Thanks and more power!

@indus

This comment has been minimized.

Copy link
Member

commented May 11, 2019

Welcome https://ngxcebu.js.org

@indus indus merged commit 17efc4f into js-org:master May 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.