Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add donation link #3036

Closed

Conversation

Projects
None yet
3 participants
@DaniellMesquita
Copy link
Contributor

commented May 15, 2019

On start page, while not reading its GitHub repo, I were looking for its donation button.

Add donation link
On start page, while not reading its GitHub repo, I were looking for its donation button.
Show resolved Hide resolved index.html Outdated
@indus

This comment has been minimized.

Copy link
Member

commented May 16, 2019

@DaniellMesquita Are you actually going to donate something? Because that is quite a rare case. It only happend once - but that is ok for me. I don't want to make it look like this project depends much on donations. You have to know our expenses are really low (~ $15/y) at the moment.

I've seen you've added JS.ORG to https://openplanetinitiative.github.io/ in the "we support" section. Could you please explain to me what kind of support I have missed or should expect?

@DaniellMesquita

This comment has been minimized.

Copy link
Contributor Author

commented May 16, 2019

Are you actually going to donate something?

Yes, if I have enough.

It only happend once - but that is ok for me.

Probably because it is only on README.md.
I think some users think is enough to read the site, and uses the GitHub repo only for submiting a pull request.

I don't want to make it look like this project depends much on donations.

Eh, the badge already says it is just for covering registrar fees.

I've seen you've added JS.ORG to https://openplanetinitiative.github.io/ in the "we support" section. Could you please explain to me what kind of support I have missed or should expect?

Support with suggestions, donations, coordinated helps, advertising, or anything OPI could do to support it.
Same for any other supported project.

@DaniellMesquita

This comment has been minimized.

Copy link
Contributor Author

commented May 16, 2019

Np if you decide to reject this PR. Just opened it as I'd looked on site for a donation button, and probably other users would want to but with no idea to look at README.md.

Show resolved Hide resolved index.html Outdated
@@ -95,6 +95,7 @@ <h3>4</h3>To finish the procedure, make a pull request in our GitHub
<a title="JS.ORG | Dedicated to JavaScript and its awesome community since 2015" href="/">&#xe600;
<span>&#xe602;</span>
</a>
<a title="Donate" rel="nofollow noreferrer noopener" target="_blank" href="https://www.paypal.com/cgi-bin/webscr?cmd=_s-xclick&hosted_button_id=RPBWBDBKW62AC"><img src="https://img.shields.io/badge/Donate-for_registrar_fees-blue.svg?style=flat-square&logo=paypal"/></a>

This comment has been minimized.

Copy link
@MattIPv4

MattIPv4 May 17, 2019

Collaborator

This needs some spacing between it and the js.org logo as currently, they are touching which does not look good.

indus added a commit that referenced this pull request May 17, 2019

@indus

This comment has been minimized.

Copy link
Member

commented May 17, 2019

I've added it instead of the second logo: 76f440e
(and made some adjustments to CSS).

Lets see how it works (and maybe revert the change).

@indus indus closed this May 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.