Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taha.js.org #3195

Merged
merged 1 commit into from Jul 10, 2019

Conversation

Projects
None yet
3 participants
@ORcxzjeeeee
Copy link
Contributor

commented Jul 9, 2019

@MattIPv4
Copy link
Member

left a comment

Commit valid, CNAME present, site appears to have content *

* based off https://github.com/ORcxzjeeeee/taha/tree/gh-pages

@MattIPv4 MattIPv4 changed the title Add taha taha.js.org Jul 9, 2019

@indus

This comment has been minimized.

Copy link
Member

commented Jul 9, 2019

I've already added your requested subdomain to JS.ORGs zonefile. But I was unable to have a look at the page because of some issues with your assets. Could you please fix them so I can have a look.
I'll merge after that.

@indus indus added the bug label Jul 9, 2019

@ORcxzjeeeee

This comment has been minimized.

Copy link
Contributor Author

commented Jul 9, 2019

I've already fixed the assets issue but I can't see the changes but it's okay in local. I think it's because of Github servers caching.

Edit: Now it's okay.

@indus indus removed the bug label Jul 10, 2019

@indus

This comment has been minimized.

Copy link
Member

commented Jul 10, 2019

@indus indus merged commit 1e0f1de into js-org:master Jul 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.