Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pulse.js.org #3201

Merged
merged 2 commits into from Jul 13, 2019

Conversation

Projects
None yet
3 participants
@TheTetrabyte
Copy link
Contributor

commented Jul 10, 2019

Since this is a zeit's now page it does not use github pages, you can see the docs here that it will be pointing to at https://pulsejs-docs.ijamespine.now.sh

The repo for the docs is here: https://github.com/jamiepine/pulse

Because this is zeit's now I'll also need a TXT record with the following options if possible.

Name: _now
Value: QmVJq8GbX4suj9cTVRHy4ARjZHqkHgAzCBP8PLFbqx1bxj

@MattIPv4
Copy link
Member

left a comment

Commit valid, site has content based on https://pulsejs-docs.ijamespine.now.sh/

@MattIPv4 MattIPv4 changed the title Add pulse pointing to zeit's now for pulse pulse.js.org Jul 10, 2019

@indus

This comment has been minimized.

Copy link
Member

commented Jul 11, 2019

@TheTetrabyte Do you know if this TXT record has to be evaluated only once or does it have to persist. Because there only can be one TXT record for _now and therefore only one page hosted on now. This wouldn't be an option for me.
Nevertheless I've added the records to give it a try. I was not able to open the page. Also be aware that the TXT record will be removed or changed in the future.

@TheTetrabyte

This comment has been minimized.

Copy link
Contributor Author

commented Jul 11, 2019

I can understand that, it does look like they might run periodic verifications on the domain, but I could be wrong and It's still worth a try, I'm not sure if they always check the txt record. But as far as I'm aware you can have multiple txt records of the same name on one domain as I've shown below.

CloudFlare DNS

Dig results

Dig Results

Still waiting for zeit to realize the TXT record change and we'll see if it works or not on the pulse.js.org domain.

@TheTetrabyte

This comment has been minimized.

Copy link
Contributor Author

commented Jul 11, 2019

Also from just a few checks, dig cannot find the cname record on the domain for pulse.js.org I could be wrong and maybe you didn't add this yet.

If you read the file I changed. I requested.
(CNAME) pulse.js.org -> alias.zeit.co (No Proxy/Orange Cloud)

@indus

This comment has been minimized.

Copy link
Member

commented Jul 11, 2019

@TheTetrabyte Didn't knew about the possibility for having two TXT records with the same name.
I accidentally enabled the CF proxy (organge cloud). I have turned it off already.

@TheTetrabyte

This comment has been minimized.

Copy link
Contributor Author

commented Jul 11, 2019

@indus I might have to contact zeit, as I'm still unsure why they're unable to verify the domain when the TXT record is clearly there. Will reply here if the verification process works or continues to fail.

@TheTetrabyte

This comment has been minimized.

Copy link
Contributor Author

commented Jul 11, 2019

Any chance we could add _now.pulse as the txt record with the same value (Leaving the old one there just in case) Just a suggestion from zeit as it's propagated but not passing verification yet.

@indus

This comment has been minimized.

Copy link
Member

commented Jul 12, 2019

_now.pulse TXT record was added.

@TheTetrabyte

This comment has been minimized.

Copy link
Contributor Author

commented Jul 12, 2019

Pretty sure it was the _now.pulse txt record, but I'm still not 100% sure. But it passed verification and works perfectly.

https://pulse.js.org/

Commit where now added the alias
jamiepine/pulse@f112db8

@MattIPv4

This comment has been minimized.

Copy link
Member

commented Jul 12, 2019

I would assume it was the _now.pulse record - I imagine they check for the _now TXT record at whatever host level you are using. Aka they treat the full pulse.js.org as the domain.

@TheTetrabyte

This comment has been minimized.

Copy link
Contributor Author

commented Jul 12, 2019

Yeah, that was the suggestion of someone from zeit. It would make sense and allows for multiple now.sh sites in the future on js,org without any trouble so it's a win.

@indus

This comment has been minimized.

Copy link
Member

commented Jul 13, 2019

@indus indus merged commit 0d2e1e7 into js-org:master Jul 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.