Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devsession.js.org #3202

Merged
merged 2 commits into from Jul 11, 2019

Conversation

Projects
None yet
3 participants
@lukasbach
Copy link
Contributor

commented Jul 10, 2019

lukasbach added some commits Jul 10, 2019

@MattIPv4
Copy link
Member

left a comment

Hi there!

Before we can accept your domain request, you need to create a file named CNAME in the root of your github pages site (this may not be the root of your repository). 📝
This file should contain a single line with the full js.org domain you are requesting, in this instance devsession.js.org.

@lukasbach

This comment has been minimized.

Copy link
Contributor Author

commented Jul 10, 2019

Oh sorry, I've added the CNAME file to the wrong directory. Should be fixed now.

@MattIPv4
Copy link
Member

left a comment

Commit valid, CNAME present, site appears to have content *

* based off https://github.com/lukasbach/devsession/tree/gh-pages

@indus indus added the bug label Jul 11, 2019

@indus

This comment has been minimized.

Copy link
Member

commented Jul 11, 2019

@lukasbach
I've already added your requested subdomain to JS.ORGs zonefile. But your site is having path issues. Please fix them to give me a chnace to have a look at it.
I'll merge afterwards.

@lukasbach

This comment has been minimized.

Copy link
Contributor Author

commented Jul 11, 2019

Sorry, I've resolved the path issues.

@indus

This comment has been minimized.

Copy link
Member

commented Jul 11, 2019

Welcome https://devsession.js.org

@indus indus merged commit 2706d63 into js-org:master Jul 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.