Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trello.js.org #3279

Merged
merged 1 commit into from Aug 8, 2019

Conversation

@wr1ght
Copy link
Contributor

commented Aug 7, 2019

trello.js.org
- [x] There is reasonable content on the page (see: [No Content](https://github.com/js-org/js.org/wiki/No-Content))
- [x] I have read and accepted the [Terms and Conditions](http://js.org/terms.html)
@MattIPv4
Copy link
Member

left a comment

Hi there!

Before we can accept your domain request, you need to create a file named CNAME in the root of your github pages site (this may not be the root of your repository). 📝
This file should contain a single line with the full js.org domain you are requesting, in this instance trello.js.org.

@wr1ght

This comment has been minimized.

Copy link
Contributor Author

commented Aug 8, 2019

@MattIPv4
Copy link
Member

left a comment

Hi there!

Before we can accept your js.org domain request, your site must have reasonable content.
Based on https://github.com/wr1ght/trellojs your site currently does not contain what we would consider to be reasonable content to grant a request.

Please see the wiki article: https://github.com/js-org/js.org/wiki/No-Content 📖

@MattIPv4 MattIPv4 added no content and removed awaiting CNAME labels Aug 8, 2019

@wr1ght

This comment has been minimized.

Copy link
Contributor Author

commented Aug 8, 2019

Hello @MattIPv4,

The content for the page is located in /docs and GitHub Pages is set to serve content from /docs in the master branch. Upon normally visiting the site from wr1ght.github.io/trellojs, you would be greeted with a documentation page, but this is not accessible yet due to the CNAME overriding the github.io

https://github.com/wr1ght/trellojs/tree/master/docs

This is a startup docsify page.

@MattIPv4

This comment has been minimized.

Copy link
Member

commented Aug 8, 2019

Ah right, I assumed it was being served from the root of master. A bit confusing with a CNAME at master root, in master/docs as well as in the gh-pages branch.

@MattIPv4
Copy link
Member

left a comment

Commit valid, CNAME present, site appears to have content *

* based off https://github.com/wr1ght/trellojs/tree/master/docs

@MattIPv4 MattIPv4 added add project user and removed no content labels Aug 8, 2019

@indus

This comment has been minimized.

Copy link
Member

commented Aug 8, 2019

@indus indus merged commit d436150 into js-org:master Aug 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.