Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gamingnet.js.org #3282

Merged
merged 2 commits into from Aug 9, 2019

Conversation

@GamingMineblox
Copy link
Contributor

commented Aug 8, 2019

@MattIPv4
Copy link
Member

left a comment

Hi there!

Before we can accept your domain request, you need to create a file named CNAME in the root of your github pages site (this may not be the root of your repository). 📝
This file should contain a single line with the full js.org domain you are requesting, in this instance gamingnet.js.org.

@GamingMineblox

This comment has been minimized.

Copy link
Contributor Author

commented Aug 8, 2019

@MattIPv4

I added the cname file
i hope i dident forget anything this time

@MattIPv4
Copy link
Member

left a comment

Based on https://github.com/GamingMineblox/GamingNet/tree/gh-pages your "site" appears to just be a copy of a website template with almost no customisations. I do not see this as a good use of a js.org subdomain.

@MattIPv4 MattIPv4 added no content and removed awaiting CNAME labels Aug 8, 2019

@GamingMineblox

This comment has been minimized.

Copy link
Contributor Author

commented Aug 9, 2019

i updated the content to my old site
is this okay?

@MattIPv4

This comment has been minimized.

Copy link
Member

commented Aug 9, 2019

@GamingMineblox Looks like you've removed the CNAME file...

@MattIPv4 MattIPv4 added awaiting CNAME and removed no content labels Aug 9, 2019

@GamingMineblox

This comment has been minimized.

Copy link
Contributor Author

commented Aug 9, 2019

i re-added it @MattIPv4

@MattIPv4

This comment has been minimized.

Copy link
Member

commented Aug 9, 2019

@GamingMineblox It looks like your site is being served from gh-pages and the CNAME is still missing from there...

@GamingMineblox

This comment has been minimized.

Copy link
Contributor Author

commented Aug 9, 2019

omg i always add it but it gets removed (my friends like to troll me with my github pages)
it is in there now
@MattIPv4

@MattIPv4
Copy link
Member

left a comment

Commit valid, CNAME present, site appears to have content *

* based off https://github.com/GamingMineblox/GamingNet/tree/gh-pages

@MattIPv4 MattIPv4 added add project user and removed awaiting CNAME labels Aug 9, 2019

@GamingMineblox

This comment has been minimized.

Copy link
Contributor Author

commented Aug 9, 2019

image

what does that mean?

@MattIPv4

This comment has been minimized.

Copy link
Member

commented Aug 9, 2019

@GamingMineblox You need to wait for this to be merged by @indus and for your request to be added to the js.org DNS zone file.

@indus

This comment has been minimized.

Copy link
Member

commented Aug 9, 2019

Welcome https://gamingnet.js.org

@indus indus merged commit 7e50f9b into js-org:master Aug 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.