Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

viveksharmaui.js.org #3332

Closed
wants to merge 2 commits into from

Conversation

@viveksharmaui
Copy link
Contributor

commented Sep 2, 2019

@MattIPv4
Copy link
Member

left a comment

Hi there!

You appear to have merged the gh-pages branch into the master branch. 😣
To add your own domain you should be forking the master branch here, editing cnames_active.js to add your domain and then making a pull request back to our master branch from your forked master branch.

Please take a look at https://github.com/js-org/js.org/wiki/Branch-Error for more information 📖

@MattIPv4 MattIPv4 closed this Sep 2, 2019

@viveksharmaui

This comment has been minimized.

Copy link
Contributor Author

commented Sep 2, 2019

Ok i got it i will create an other pull request for fixing this issue :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.