Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

engine262.js.org #3338

Merged
merged 3 commits into from Sep 3, 2019

Conversation

@TimothyGu
Copy link
Contributor

commented Sep 2, 2019

TimothyGu added 2 commits Sep 2, 2019
@TimothyGu

This comment has been minimized.

Copy link
Contributor Author

commented Sep 2, 2019

@indus indus changed the title Use NS for engine262 engine262.js.org Sep 2, 2019

@indus

This comment has been minimized.

Copy link
Member

commented Sep 2, 2019

Why do you need NS records. There are only rare cases where we accept them (as you can see by the number of records ;-)

@theabbie

This comment has been minimized.

Copy link
Contributor

commented Sep 2, 2019

@TimothyGu use TXT records it is very easy

@TimothyGu

This comment has been minimized.

Copy link
Contributor Author

commented Sep 2, 2019

Yeah I'm aware. However we'd like to be able to configure api.engine262.js.org, etc. Also, how do you add TXT records for js.org domains?

@MattIPv4

This comment has been minimized.

Copy link
Member

commented Sep 2, 2019

@TimothyGu I've just had a chat with @devsnek and my understanding is that this is just to verify domain ownership in Zeit and then you're moving to Cloudflare DNS?

If so, why not request Cf NS here now and then verify Zeit ownership once you have NS control?

@theabbie

This comment has been minimized.

Copy link
Contributor

commented Sep 2, 2019

@TimothyGu like this
#3333

@theabbie

This comment has been minimized.

Copy link
Contributor

commented Sep 2, 2019

@TimothyGu once you verify ownership for engine.js.org all it's subdomains ie. *.engine.js.org will be yours

@TimothyGu

This comment has been minimized.

Copy link
Contributor Author

commented Sep 2, 2019

There seem to be various options:

  1. Use Cloudflare's NS
  2. Use Zeit's NS
  3. Use TXT records with Zeit

Which one of these three are folks actually okay with?

@indus

This comment has been minimized.

Copy link
Member

commented Sep 2, 2019

@MattIPv4 I prefer the TXT record method. I really want to keep the number of NS records in in JS.ORG small.

@devsnek

This comment has been minimized.

Copy link
Contributor

commented Sep 2, 2019

I'd prefer the zone was not controlled directly by zeit, but if that's the preferred way then it's fine.

@MattIPv4

This comment has been minimized.

Copy link
Member

commented Sep 2, 2019

@indus If they are wanting to use sub-domains of their js.org sub-domain, would it not make sense to use NS records here and let them have control?

Moving this sub-domain to their Cloudflare DNS makes the most sense as they can then do as they please (Zeit verification etc).

@indus

This comment has been minimized.

Copy link
Member

commented Sep 2, 2019

Just an hour ago @theabbie told me that it is possible to have control of sub-sub-domains with zeit #3333 (comment)_
Maybe you want to give that a try first?

@MattIPv4

This comment has been minimized.

Copy link
Member

commented Sep 2, 2019

@theabbie Are you sure that sub-sub-domains are actually working? From my understanding of DNS, a single CNAME would not enable the functionality. Have you actually tried it? It may just be Zeit saying you can when it won't actually work?

@TimothyGu

This comment has been minimized.

Copy link
Contributor Author

commented Sep 3, 2019

@indus Sure. In that case, could you add the following record?

TXT _now.engine262.js.org QmU1DRVethHkroFqHSKw3EAv4q3V7p2QhGSW4rG7GeM1NW
@theabbie

This comment has been minimized.

Copy link
Contributor

commented Sep 3, 2019

@MattIPv4 suppose i have a domain abc.com and i verify it with zeit then it allows you to have *.abc.com ,*. something.abc.com,*. something. something. abc.com without any further verification, eg. i verified 1by0.tk on zeit and added wildcard subdomain *.1by0.tk and all subdomains were hosted on same nodejs app, thus we could give dynamic responses as per subdomain i was also able to add *.0.1by0.tk ie. a wildcard sub sub domain, i don't know about engine262.js.org, but i don't think there is anything for it to not work

@devsnek

This comment has been minimized.

Copy link
Contributor

commented Sep 3, 2019

@theabbie we mean, have you actually tested that with a subdomain from js.org? I would expect cloudflare to NXDOMAIN the request for *.subdomain.js.org, since there is no entry for it, just the CNAME for subdomain.js.org.

@theabbie

This comment has been minimized.

Copy link
Contributor

commented Sep 3, 2019

@devsnek yeah, you are correct it requires nameserver verification for subdomains to work

@theabbie

This comment has been minimized.

Copy link
Contributor

commented Sep 3, 2019

@devsnek but @indus and @MattIPv4 say that there is only limited space for nameservers

@theabbie

This comment has been minimized.

Copy link
Contributor

commented Sep 3, 2019

@theabbie

This comment has been minimized.

Copy link
Contributor

commented Sep 3, 2019

@devsnek @indus @MattIPv4 i don't understand what's the role of cloudflare in this, if the domain is bought from namecheap.com and hosted on zeit what's cloudflare doing in between

@devsnek

This comment has been minimized.

Copy link
Contributor

commented Sep 3, 2019

cloudflare is the authoritative nameserver for js.org. So when your browser looks for awto.js.org, it asks cloudflare where it goes (well it asks the root nameservers first, but meh). Cloudflare has been configured by indus to have a CNAME record pointing from awto.js.org to alias.zeit.co (which cloudflare automatically flattens into an A record but that's not important):

What cloudflare doesn't have is an entry for *.awto.js.org, and there is no response for such domains:

@theabbie

This comment has been minimized.

Copy link
Contributor

commented Sep 3, 2019

@devsnek and what about limited nameservers?

@devsnek

This comment has been minimized.

Copy link
Contributor

commented Sep 3, 2019

i don't know the exact details, but cloudflare has a limit on the number of records a domain can have.

@theabbie

This comment was marked as off-topic.

Copy link
Contributor

commented Sep 3, 2019

@devsnek if we use a freenom domain we can have wildcard subdomain and sub subdomain on zeit if we use nameserver method

@theabbie

This comment was marked as off-topic.

Copy link
Contributor

commented Sep 3, 2019

@devsnek doesn't namecheap.com have an option to add dns records

@MattIPv4

This comment has been minimized.

Copy link
Member

commented Sep 3, 2019

This conversation has detoured drastically.

@TimothyGu @devsnek You're wanting to use sub-sub-domains, so you'll want to use Zeit NS records as per this PR.

ns_active.js Outdated Show resolved Hide resolved
@theabbie

This comment was marked as off-topic.

Copy link
Contributor

commented Sep 3, 2019

@MattIPv4 even i need nameserver

@MattIPv4 MattIPv4 added add NS labels Sep 3, 2019

Resolved.

@MattIPv4
Copy link
Member

left a comment

Lgtm.

@indus

This comment has been minimized.

Copy link
Member

commented Sep 3, 2019

To bring this to an end. I see a legit reason here.
Goodbye CNAME welcome NS...

@indus indus merged commit 5507ef1 into js-org:master Sep 3, 2019

@theabbie theabbie referenced this pull request Sep 3, 2019
2 of 2 tasks complete
@devsnek

This comment has been minimized.

Copy link
Contributor

commented Sep 3, 2019

can this be reverted? zeit is doing bad things (https://gc.gy/dc74abe0-7aa4-4c3f-83ae-c1480960517a.png) and i would rather not have it in control of the zone.

@theabbie

This comment has been minimized.

Copy link
Contributor

commented Sep 3, 2019

@devsnek you must have removed domain and added it again

@indus

This comment has been minimized.

Copy link
Member

commented Sep 3, 2019

@devsnek I've changed the NS records to the ones in the screenshot. If this doesn't work I can revert to the CNAME pointing to github (But I won't add and remove records all day long)

@TimothyGu

This comment has been minimized.

Copy link
Contributor Author

commented Sep 3, 2019

Just got an email saying it has been verified. Thanks everyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.