Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regraph.js.org #3372

Merged
merged 1 commit into from Sep 14, 2019
Merged

regraph.js.org #3372

merged 1 commit into from Sep 14, 2019

Conversation

Izhaki
Copy link
Contributor

@Izhaki Izhaki commented Sep 13, 2019

Hello again!

Another one from me.

https://izhaki.github.io/regraph/ is slightly broken right now as NextJs needs special configuration when not served from site root (which is pointless to do since I'll have to revert it as soon is this PR is merged)

Thank you!!!!

Hello again!

Another one from me.

https://izhaki.github.io/regraph/ is slightly broken right now as NextJs needs special configuration when not served from site root (which is pointless to do since I'll have to revert it as soon is this PR is merged)

Thank you!!!!
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there!

Before we can accept your domain request, you need to create a file named CNAME in the root of your github pages site (this may not be the root of your repository). 📝
This file should contain a single line with the full js.org domain you are requesting, in this instance regraph.js.org.

@MattIPv4 MattIPv4 added the awaiting CNAME This PR is waiting for the target to add a CNAME file label Sep 14, 2019
@Izhaki
Copy link
Contributor Author

Izhaki commented Sep 14, 2019

Hi @MattIPv4

I think this option is now given in github:

image

But when I try to set it to regraph.js.org I get:

image

Let me try to set CNAME manually

@MattIPv4
Copy link
Member

That error is fine, it has applied and will work once we set it up on our end.

@Izhaki
Copy link
Contributor Author

Izhaki commented Sep 14, 2019

Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Commit valid, CNAME present, site appears to have content *

* based off https://github.com/Izhaki/regraph/tree/gh-pages

@MattIPv4 MattIPv4 added add This PR/issue is regarding adding a new subdomain project This PR has a target of a project on an organisation or user account user This PR/issue is regarding a target on a GitHub user account and removed awaiting CNAME This PR is waiting for the target to add a CNAME file labels Sep 14, 2019
@indus
Copy link
Member

indus commented Sep 14, 2019

Welcome https://regraph.js.org

@indus indus merged commit a50bd2a into js-org:master Sep 14, 2019
@Izhaki
Copy link
Contributor Author

Izhaki commented Sep 14, 2019

Cheers lads!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add This PR/issue is regarding adding a new subdomain project This PR has a target of a project on an organisation or user account user This PR/issue is regarding a target on a GitHub user account
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants