Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

machinelearning.js.org #3435

Merged
merged 1 commit into from Oct 8, 2019

Conversation

@marink
Copy link
Contributor

commented Oct 8, 2019

Copy link
Member

left a comment

Hi there!

Before we can accept your domain request, you need to create a file named CNAME in the root of your github pages site (this may not be the root of your repository). 📝
This file should contain a single line with the full js.org domain you are requesting, in this instance machinelearning.js.org.

@MattIPv4 MattIPv4 changed the title Add machine learning js library. machinelearning.js.org Oct 8, 2019
@marink marink requested a review from MattIPv4 Oct 8, 2019
Copy link
Member

left a comment

Hi there!

Before we can accept your js.org domain request, your site must have reasonable content.
Based on https://github.com/marink/machinelearning/tree/gh-pages your site currently does not contain what we would consider to be reasonable content to grant a request.

Please see the wiki article: https://github.com/js-org/js.org/wiki/No-Content 📖

@MattIPv4 MattIPv4 added no content and removed awaiting CNAME labels Oct 8, 2019
@marink

This comment has been minimized.

Copy link
Contributor Author

commented Oct 8, 2019

Matt,
I added the CNAME file (gh-pages branch), - at one point I had it there, but not sure why I had deleted it.

@indus

This comment has been minimized.

Copy link
Member

commented Oct 8, 2019

Welcome https://machinelearning.js.org
(I`'ve marked this as "provisional content" to make sure to check pback on your page and have a look at the content in the future)

@indus indus merged commit fb45859 into js-org:master Oct 8, 2019
@marink marink deleted the marink:patch-1 branch Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.