Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ero.js.org #3515

Merged
merged 2 commits into from Nov 9, 2019

Conversation

@MST-2
Copy link
Contributor

MST-2 commented Nov 5, 2019

MST-2 and others added 2 commits Nov 5, 2019
Copy link
Member

MattIPv4 left a comment

Commit valid, CNAME present, site has limited content *

* based off https://github.com/MST-2/ero

@indus indus changed the title Update cnames_active.js ero.js.org Nov 6, 2019
@indus

This comment has been minimized.

Copy link
Member

indus commented Nov 6, 2019

I've already added your requested subdomain to JS.ORGs zonefile. But something is wrong with your GitHub page. I'm not sure but maybe itr has to be a "Reame.md" to get converted to a index.html
I will have to fix this before I will merge.

@MST-2

This comment has been minimized.

Copy link
Contributor Author

MST-2 commented Nov 6, 2019

I‘m using a Jekyll Theme. Usually you just need the one .md file, but I will check.

@indus indus added the bug label Nov 7, 2019
@indus

This comment has been minimized.

Copy link
Member

indus commented Nov 7, 2019

@MST-2 have you tried to fix it? https://ero.js.org/ is allready pointing to Github but the request doesn't get picked up by their servers. There is still something wrong with your Github page. Maybe you try to trigger some a re-evaluation by removing the MD file and adding it back again.

@MST-2

This comment has been minimized.

Copy link
Contributor Author

MST-2 commented Nov 8, 2019

I‘ll try that. I will keep you updated.

@MST-2

This comment has been minimized.

Copy link
Contributor Author

MST-2 commented Nov 8, 2019

Deleted and re-added it again. Let‘s see what happens.

@indus indus removed the bug label Nov 9, 2019
@indus

This comment has been minimized.

Copy link
Member

indus commented Nov 9, 2019

LGTM Welcome https://ero.js.org

@indus indus merged commit 80c3d55 into js-org:master Nov 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.