Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xyz.js.org #3520

Closed
wants to merge 1 commit into from

Conversation

@masterde
Copy link

masterde commented Nov 7, 2019

Nuxt.js + Semantic UI

Nuxt.js + Semantic UI
Copy link
Member

MattIPv4 left a comment

Hi there!

Before we can accept your domain request, you need to create a file named CNAME in the root of your github pages site (this may not be the root of your repository). 📝
This file should contain a single line with the full js.org domain you are requesting, in this instance xyz.js.org.

@masterde

This comment has been minimized.

Copy link
Author

masterde commented Nov 7, 2019

Its already there.

@MattIPv4

This comment has been minimized.

Copy link
Member

MattIPv4 commented Nov 7, 2019

curl -I https://xyzrepo.github.io/XYZ/    
                                                                                                                                                           
HTTP/2 200 
server: GitHub.com
content-type: text/html; charset=utf-8
strict-transport-security: max-age=31556952
last-modified: Thu, 07 Nov 2019 01:59:05 GMT
etag: "5dc37a69-2e14"
access-control-allow-origin: *
expires: Thu, 07 Nov 2019 09:48:00 GMT
cache-control: max-age=600
x-proxy-cache: MISS
x-github-request-id: F702:705C:60844B:7B613A:5DC3E5F8
accept-ranges: bytes
date: Thu, 07 Nov 2019 09:38:06 GMT
via: 1.1 varnish
age: 6
x-served-by: cache-lhr7320-LHR
x-cache: HIT
x-cache-hits: 1
x-timer: S1573119487.745934,VS0,VE0
vary: Accept-Encoding
x-fastly-request-id: 0d850dd9a212c8d89ccbb9afce3faf88063f0b27
content-length: 11796

It isn't in the correct place, or GitHub pages hasn't detected it. Please check your repository settings, and the GitHub pages section to confirm that the custom domain is working.

@masterde

This comment has been minimized.

Copy link
Author

masterde commented Nov 7, 2019

Made some changes, please check again

@indus

This comment has been minimized.

Copy link
Member

indus commented Nov 7, 2019

As stated in the readme I'm not accepting requests for pages without content. A vanilla template is not "reasonable content". I´m going to close this but feel free to open a new PR when your page is ready for the public.

@indus indus closed this Nov 7, 2019
@masterde

This comment has been minimized.

Copy link
Author

masterde commented Nov 7, 2019

As stated in the readme I'm not accepting requests for pages without content. A vanilla template is not "reasonable content". I´m going to close this but feel free to open a new PR when your page is ready for the public.

I'm just trying to get it to work before I add my content, because I keep getting a CNAME already taken error.

@indus

This comment has been minimized.

Copy link
Member

indus commented Nov 8, 2019

@masterde It would have worked. i've seen the vailla template in browser. Nevertheless "reasonable content" is a requirement before we accept a PR. Without content the PR gets closed. otherwise we would have to track a lot of open PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.