Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

naseem.js.org #3643

Merged
merged 1 commit into from Jan 8, 2020
Merged

naseem.js.org #3643

merged 1 commit into from Jan 8, 2020

Conversation

@naseemali925
Copy link
Contributor

naseemali925 commented Jan 7, 2020

@naseemali925 naseemali925 changed the title Update cnames_active.js naseem.js.org Jan 7, 2020
Copy link
Member

MattIPv4 left a comment

Commit valid, CNAME present, site appears to have content *

* based off https://github.com/naseemali925/about-me/tree/gh-pages

@indus indus added the bug label Jan 7, 2020
@indus

This comment has been minimized.

Copy link
Member

indus commented Jan 7, 2020

@naseemali925
I've already added your requested subdomain to JS.ORGs zonefile. But it looks like some paths are incorrect now. Please fix that and I'll merge after I had a look at your page.

@naseemali925

This comment has been minimized.

Copy link
Contributor Author

naseemali925 commented Jan 7, 2020

@indus Sure. I will update you once those paths are fixed. Thanks.

@naseemali925

This comment has been minimized.

Copy link
Contributor Author

naseemali925 commented Jan 7, 2020

@indus I have fixed the paths. You can take a look and then merge the pull request.

@indus indus removed the bug label Jan 8, 2020
@indus

This comment has been minimized.

Copy link
Member

indus commented Jan 8, 2020

@indus indus merged commit 17629bf into js-org:master Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.