Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imagecapture.js.org #846

Merged
merged 3 commits into from Oct 3, 2016

Conversation

@dandv
Copy link
Contributor

commented Oct 3, 2016

I've followed the instructions and created the CNAME file, but if I go to https://dandv.github.io/imagecapture right now, I'm already redirected to imagecapture.js.org. Won't this lead to a redirect loop after the subdomain goes live?

  • There is reasonable content on the page (see: No Content)
  • I have read and accepted the ToS

@indus indus changed the title Add imagecapture imagecapture.js.org Oct 3, 2016

@indus

This comment has been minimized.

Copy link
Member

commented Oct 3, 2016

Won't this lead to a redirect loop after the subdomain goes live?

No - a CNAME record in a DNS zonefile is not a redirect like "status 304". It is more like a redirect...

Welcome imagecapture.js.org

But when you have already tried it (like you mentioned), you will probably face DNS caching right now. This may happen on browser, os or even router level. You can check DNS Propagation with tools like: https://www.dotcom-tools.com/website-speed-test.aspx

@dandv

This comment has been minimized.

Copy link
Contributor Author

commented Oct 3, 2016

Thanks! I didn't want CF initially because this is a rapidly-changing project and caching would hurt more than help, but it does absolutely need HTTPS for getUserMedia to work. Can you please enable it?

@indus

This comment has been minimized.

Copy link
Member

commented Oct 3, 2016

Can you make a new PR removing the flag, please. I will enable it in the meantime, but for the record it would be nice.

@dandv

This comment has been minimized.

Copy link
Contributor Author

commented Oct 3, 2016

Sure. I thought the second commit was sufficient, but I can make a new PR.

@indus

This comment has been minimized.

Copy link
Member

commented Oct 3, 2016

No just remove the comment in this PR. Cloudflares Universial SSL is the default.

@dandv

This comment has been minimized.

Copy link
Contributor Author

commented Oct 3, 2016

Is this second commit sufficient? Or do you mean I should remove the HTTPS comment altogether?

@indus

This comment has been minimized.

Copy link
Member

commented Oct 3, 2016

please remove it altogether

@dandv

This comment has been minimized.

Copy link
Contributor Author

commented Oct 3, 2016

Done. Probably should be squashed&merged.

@dandv

This comment has been minimized.

Copy link
Contributor Author

commented Oct 3, 2016

Gotta love live GitHub updates.

@indus

This comment has been minimized.

Copy link
Member

commented Oct 3, 2016

Thanks. I´ve enabled Universal SSL. But once again this may take some time to propagate (minutes to hours)

@dandv

This comment has been minimized.

Copy link
Contributor Author

commented Oct 3, 2016

It already works!

@dandv dandv closed this Oct 3, 2016

@indus

This comment has been minimized.

Copy link
Member

commented Oct 3, 2016

@indus indus reopened this Oct 3, 2016

@indus indus merged commit 9bc4dda into js-org:master Oct 3, 2016

@dandv dandv deleted the dandv:patch-1 branch Oct 3, 2016

@dandv

This comment has been minimized.

Copy link
Contributor Author

commented Oct 3, 2016

Thanks!

Maybe I don't understand CNAME-ing and js.org properly - but would it be possible to have just imagecapture.js.org (re)direct to https://dandv.github.io/imagecapture, but if the user goes to https://dandv.github.io/imagecapture, they should remain at that URL?

@indus

This comment has been minimized.

Copy link
Member

commented Oct 3, 2016

I´m sorry but thats not possible because GitHub decided to make a redirect (!) when there is an active CNAME in the repo. This changed a couple of months ago. Before that it was like you wish now. I´m sorry but I don´t have any influence what GitHub does when you reach one of their endpoints and I don´t know a way to avoid the redirect.

@indus

This comment has been minimized.

@indus

This comment has been minimized.

@dandv

This comment has been minimized.

Copy link
Contributor Author

commented Oct 3, 2016

Thanks. Just curious, why do your apostrophes look like a reflected backtick? Is it a German keyboard layout thing?

@indus

This comment has been minimized.

Copy link
Member

commented Oct 3, 2016

Maybe I‘m (I'm) just using them wrong - for my whole bilingual live. In german there is no need for any sort of tick (not like the french; I think they use ALL of them). So I'‘’m not very used to them and misused them.

Is this ' the correct one?

@dandv

This comment has been minimized.

Copy link
Contributor Author

commented Oct 3, 2016

The one in the standard ASCII (code 39) is the correct one for English. I'm also not a native speaker :)

@indus

This comment has been minimized.

Copy link
Member

commented Oct 3, 2016

Many thanks for the hint. I'm sure a lot of people wondered already but nobody wanted to point me to my mistake. Thanks.

@dandv

This comment has been minimized.

Copy link
Contributor Author

commented Oct 3, 2016

For about 10 years, I had spelled the 10th month of the year as "Octomber", until I used spell checking in Word.

@indus

This comment has been minimized.

Copy link
Member

commented Oct 3, 2016

Funny. This feels a bit like looking into a mirror finding some spinach between your teeth asking yourself how many people you may have given a smile since lunch 😃

@dandv

This comment has been minimized.

Copy link
Contributor Author

commented Oct 3, 2016

That particular example may seem funny, but it made me think what else I was taking for granted and should be more skeptical about. That led to actually becoming a skeptic, questioning the Bible, then becoming an atheist and leaving my country of origin.

@indus

This comment has been minimized.

Copy link
Member

commented Oct 3, 2016

Interesting - but I don't get your point here. You've realized you made a mistake for years in language, but your way to look at religion now doesn't sound like "I made a mistake by beeing religious" but more like "Hey religion, you are wrong".

I mean you could have concluded the following as well: "I made a mistake in language for years not knowing the correct spelling of some words. Maybe I have made mistakes in religious things as well. I will try to be better with my religion and use it correct in my daily live."

I would call me a non-religous person myself. But I really don't see the need to adress questions about the bible to people in a way that may offend them.

@dandv

This comment has been minimized.

Copy link
Contributor Author

commented Oct 4, 2016

"I made a mistake in language for years not knowing the correct spelling of some words. Maybe I have made mistakes in religious things as well. I will try to be better with my religion and use it correct in my daily live."

That's how I started, indeed. I searched for the "correct" alternative to my mistake regarding drinking, which led to discovering many other - more serious - incongruities. For example, modern morality conflicts with what's preached in the Bible. Women are no longer treated as property, etc.

The Bible turned out gradually (it took me several years) to be a murky fable, and religion a huge hoax.

But I really don't see the need to adress questions about the bible to people in a way that may offend them.

Completely agree, and I would never do that out of the blue.

The context to story I linked to is that Ionica Bizau is a brilliant and talented young fellow countryman who also is a Young Earth Creationist and proselytizes about Jesus and Bible on GitHub. It just boggles my mind that he can be so rational about programming, yet hasn't critically examined the notion that the Earth is only ~8000 years old. 😕

@indus

This comment has been minimized.

Copy link
Member

commented Oct 7, 2016

dandv/imagecapture@37d35ef
is now fixed!
SSL is enforced. If you don´t want to re-add the CNAME please let me know so I can remove your record.

@dandv

This comment has been minimized.

Copy link
Contributor Author

commented Oct 7, 2016

Thanks! I've re-added the CNAME. BTW, another one of those "revelations": SSL no longer exists!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.