add license-header to dist #21

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
@fcarstens
Contributor

fcarstens commented Jul 26, 2015

Adds a license-header to a generated dist file. I'm not sure how we do best about the version information. Ideas? 馃槂

@jzaefferer

This comment has been minimized.

Show comment
Hide comment
@jzaefferer

jzaefferer Jul 27, 2015

Contributor

In other projects the source header has a @VERSION placeholder, which during the build time is replaced with the version property from package.json. Maybe using https://www.npmjs.com/package/sed.js ? Or something like that.

Contributor

jzaefferer commented Jul 27, 2015

In other projects the source header has a @VERSION placeholder, which during the build time is replaced with the version property from package.json. Maybe using https://www.npmjs.com/package/sed.js ? Or something like that.

@@ -2,7 +2,7 @@
"name": "js-reporters",
"version": "1.0.0",
"scripts": {
- "build": "mkdirp dist/ && esperanto -b -i lib/index.js -t umd --name JsReporters | babel -o dist/js-reporters.js --blacklist strict -m umd",
+ "build": "mkdirp dist/ && esperanto -b -i lib/index.js -t umd --name JsReporters | babel --blacklist strict -m umd | cat lib/license-header.js - > dist/js-reporters.js",

This comment has been minimized.

@leobalter

leobalter Jul 27, 2015

this is becoming too large.

I suggest splitting it to smaller steps or setting up a build file to be called here..

@leobalter

leobalter Jul 27, 2015

this is becoming too large.

I suggest splitting it to smaller steps or setting up a build file to be called here..

@jzaefferer

This comment has been minimized.

Show comment
Hide comment
@jzaefferer

jzaefferer Jul 31, 2015

Contributor

It looks like we're going to have ES6 JS files in test/ as well, so may as well create a separate build script.

Contributor

jzaefferer commented Jul 31, 2015

It looks like we're going to have ES6 JS files in test/ as well, so may as well create a separate build script.

@jzaefferer

This comment has been minimized.

Show comment
Hide comment
@jzaefferer

jzaefferer Aug 13, 2015

Contributor

Still need to finish this.

Contributor

jzaefferer commented Aug 13, 2015

Still need to finish this.

@fcarstens fcarstens referenced this pull request Aug 15, 2015

Closed

Improve build script #26

@fcarstens

This comment has been minimized.

Show comment
Hide comment
@fcarstens

fcarstens Aug 20, 2015

Contributor

Superseded by #26.

Contributor

fcarstens commented Aug 20, 2015

Superseded by #26.

@fcarstens fcarstens closed this Aug 20, 2015

@fcarstens fcarstens deleted the fcarstens:license-header branch Aug 20, 2015

fcarstens added a commit to fcarstens/js-reporters that referenced this pull request Aug 21, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment