New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"foo:: instanceof Bar" doesn't convert correctly to JS #138

Closed
JanMiksovsky opened this Issue May 4, 2012 · 1 comment

Comments

Projects
None yet
2 participants
@JanMiksovsky

JanMiksovsky commented May 4, 2012

The following JS:

Foo.protoype instanceof Bar

gets correctly converted to CoffeeScript:

Foo:: instanceof Bar

But going the other direction, the above CoffeeScript gets converted to:

Foo.prototype["instanceof"](Bar)

when something like the topmost JS is expected.

Aside: I'm porting the QuickUI web UI framework (http://quickui.org) to CoffeeScript, and am using js2coffee to get the port started. js2coffee did an amazing job. The converted CoffeeScript, when compiled, passes nearly all of the QuickUI unit test suite. The unmodified js2coffee output passed 112 of the 116 unit tests in the suite. The remaining 4 broken tests were due to the issue described here. Many, many thanks for the work you've put into this tool!

@timaschew

This comment has been minimized.

Member

timaschew commented Aug 23, 2014

this is not an issue of js2coffee

@timaschew timaschew closed this Aug 23, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment