Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix global leak #174

Merged
merged 1 commit into from Jan 30, 2013

Conversation

Projects
None yet
3 participants
@ForbesLindesay
Copy link
Contributor

commented Jan 7, 2013

narcissus_packed.js leaks a global Narcissus (which is not needed in order to function properly. This fixes that global leak.

Fix global leak
narcissus_packed.js leaked a global Narcissus (which is not needed in order to function properly.
@ForbesLindesay

This comment has been minimized.

Copy link
Contributor Author

commented Jan 30, 2013

This should just need rubber stamping really, and would make a huge difference to the many people depending on this module.

rstacruz added a commit that referenced this pull request Jan 30, 2013

@rstacruz rstacruz merged commit ed8f0ce into js2coffee:master Jan 30, 2013

@ForbesLindesay

This comment has been minimized.

Copy link
Contributor Author

commented Jan 30, 2013

Thanks 😄

@balupton

This comment has been minimized.

Copy link
Member

commented Jun 7, 2013

Published to v0.1.4

michaelficarra pushed a commit to michaelficarra/js2coffee that referenced this pull request Nov 13, 2013

v0.1.4. Bugfix. Improvement.
- [Fixed CoffeeScript version
problems](js2coffee#189)
  - [Use only compatible coffee-script
version](js2coffee#196)
  - [Defines RESERVED words if not
defined](js2coffee#194)
  - Rewrote to only use local coffee-script installation, rather than
using global installation
- [Fixed global leak](js2coffee#174)
- Tests now use the [Joe Test Runner](https://github.com/bevry/joe),
instead of using nothing before
- Watched, compiled, bundled, and automatically tested with
[DocPad](http://docpad.org/)
- Added [TravisCI](https://travis-ci.org/) support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.