Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deletes annotations via eraser tool #250

Merged
merged 1 commit into from Sep 18, 2019

Conversation

@rbavery
Copy link
Contributor

commented Sep 18, 2019

This fixes #169 by deleting annotations that are completely erased with the eraser tool on mouse up.

I tested this on the development build and found that it works by generating annotations and erasing them. Before the annotations would hang around as empty annotations and a point in the center would appear after erasing an annotation. Annotation IDs are reordered correctly as well when annotations are deleted.

@rbavery

This comment has been minimized.

Copy link
Contributor Author

commented Sep 18, 2019

shoutout to @marwahaha for the JS help!

@jsbroks jsbroks merged commit e26ce4e into jsbroks:master Sep 18, 2019
1 check passed
1 check passed
WIP Ready for review
Details
@rbavery rbavery deleted the ecohydro:fix-annotation-delete branch Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.