Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added color parameter type #100

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
2 participants
@cmchap
Copy link

commented Oct 8, 2015

Added the ability to include a parameter that lets the user choose a color via their operating system's built-in color picker.

I'm new to javascript and have never meaningfully contributed to OSS, so please review to be sure it matches any style/standards in the rest of the repo.

cmchap
added color parameter type
added the ability to include a parameter that lets the user choose a color via their opperating system's built-in color picker.
@z3dev

This comment has been minimized.

Copy link
Contributor

commented Oct 13, 2015

@cmchap Thanks for the changes. The code looks fine. Welcome to the world of JavaScript programming.

FYI, we have been working on some changes to add all HTML5 input types to the available parameter types, including color, range (sliders), dates, etc. These will be available very shortly in the Alpha 0.3.1 Release. Please try the new release once it becomes available.

@z3dev

This comment has been minimized.

Copy link
Contributor

commented Dec 3, 2015

@cmchap thanks again for the enhancements
OpenJSCAD.org Version 0.3.1 has been committed. This release as support for the HTLM5 color chooser. There's a new example called "Balloons" that shows how to use most of the new parameter types.
Does the new color chooser supply what you're looking for?

@cmchap

This comment has been minimized.

Copy link
Author

commented Dec 3, 2015

The new color chooser does exactly what I wanted. Thanks!

@z3dev

This comment has been minimized.

Copy link
Contributor

commented Dec 4, 2015

@cmchap thanks
I'm closing this pull request.
Please continue to submit changes and ideas.

@z3dev z3dev closed this Dec 4, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.