Unclear debug logs from CertStoreInspector #2

Closed
megahall opened this Issue Mar 28, 2013 · 4 comments

Comments

Projects
None yet
2 participants
Member

megahall commented Mar 28, 2013

public static CertStoreInspector inspect(final CertStore store) {
    try {
        Collection<? extends Certificate> certs = store
                .getCertificates(null);
        LOGGER.debug("CertStore contains {} certificate(s):", certs.size());
        int i = 0;
        for (Certificate cert : certs) {
            X509Certificate x509 = (X509Certificate) cert;
            LOGGER.debug("{}. '[issuer={}; serial={}]'", new Object[] {++i, x509.getIssuerDN(), x509.getSerialNumber()});
        }

If you have a setup with a CA cert and an RA cert, the issuer string will be the same for both certs. It would make more sense if it used the CN of the cert instead of the CN of the issuer here.

Contributor

seize-the-dave commented Mar 28, 2013

Can you create a pull request? Please note that this particular debug statement is used elsewhere (or at least something very similar), so perhaps you might like to change that too?

@ghost ghost assigned seize-the-dave Mar 28, 2013

Member

megahall commented Mar 28, 2013

Yeah, I can surely do it, if you have some directions how to open up jscep as an mvn or Eclipse project.

Right now I don't have a build environment for it, only a jar.

On Thu, Mar 28, 2013 at 01:41:46PM -0700, Dave Grant wrote:

Can you create a pull request? Please note that this particular debug statement is used elsewhere (or at least something very similar), so perhaps you might like to change that too?


Reply to this email directly or view it on GitHub:
seize-the-dave#2 (comment)

Contributor

seize-the-dave commented Mar 28, 2013

Here's what I'd do:

  1. Fork the project
  2. Get the GitHub client and checkout your branch
  3. mvn eclipse:eclipse

Give me a shout if you run into problems.

Member

megahall commented Mar 28, 2013

OK, request submitted. LMK if it looks OK or needs anything more. Thanks!

seize-the-dave added a commit that referenced this issue Mar 28, 2013

Merge pull request #3 from megahall/master
fixes #2: unclear debug logs from CertStoreInspector
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment