Skip to content

Julian Scheid
jscheid

  • Joined on
jscheid commented on pull request oozcitak/xmlbuilder-js#86
@jscheid

Hi, on a mobile phone so being brief. I don't think replacing CR like this is right. Firstly it can still leave newlines (as opposed to escaped new…

@jscheid
Replace Object.values call with for in loop
@jscheid

Fixed in bd9ba27, released as version 0.3.2. Thanks!

@jscheid
@jscheid
@jscheid

This is broken, tests are failing. Were you looking for hasOwnProperty(key)?

jscheid commented on issue uber/npm-shrinkwrap#94
@jscheid

I'm getting the same error, this works for me: $ node --stack_size=10240 $(which npm-shrinkwrap)

@jscheid
FIx test and README to use nested compiler options
1 commit with 23 additions and 31 deletions
jscheid commented on pull request roman01la/webpack-closure-compiler#5
@jscheid

By the way we've been using this branch in our continuous deployment pipeline for the last couple of months and there have been no issues, so I thi…

jscheid commented on pull request roman01la/webpack-closure-compiler#5
@jscheid

Hi @roman01la, what do you think of the code now that I've fixed the case of no options passed in? Are the default options a deal breaker for you? …

jscheid commented on pull request oozcitak/xmlbuilder-js#86
@jscheid

Please reconsider: That's like saying that the text in the following code doesn't have to be escaped because it's valid XML: builder.create({ roo…

jscheid commented on pull request oozcitak/xmlbuilder-js#86
@jscheid

Here's an example with ruby: $ irb irb(main):001:0> require 'nokogiri' => true irb(main):002:0> Nokogiri::XML("<test attr='abc\tdef'/>").xpath("//t…

jscheid commented on pull request oozcitak/xmlbuilder-js#86
@jscheid

Ah, here's the issue. I've just added a comment on the commit: cf22542 It's true that these characters are valid in attribute values, but that does…

@jscheid

Hi, I've just noticed that this undoes (the most important part of) my PR #54 :-) It means it's now again impossible to embed tabs, carriage return…

@jscheid
@jscheid
@jscheid
@jscheid
@jscheid
jscheid commented on pull request webpack/webpack#1868
@jscheid

Done.

@jscheid 1800/subresource-integrity is now d4db20a
Something went wrong with that request. Please try again.