Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #112 - Check if bucket exists for path='' #116

Merged
merged 1 commit into from Jan 26, 2016

Conversation

Projects
None yet
2 participants
@jschneier
Copy link
Owner

jschneier commented Jan 26, 2016

No description provided.

@jschneier jschneier merged commit b95ec91 into master Jan 26, 2016

1 of 2 checks passed

continuous-integration/travis-ci/push The Travis CI build is in progress
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jschneier jschneier deleted the django-19-collectstatic-c branch Jan 26, 2016

jschneier added a commit that referenced this pull request Jan 26, 2016

@mbarrien

This comment has been minimized.

Copy link
Contributor

mbarrien commented on tests/test_s3boto.py in b95ec91 Feb 11, 2016

I'm not quite sure that this test does what you think it's testing; I don't think S3ResponseError could ever be raised.

When auto_create_bucket is False (the default), then in the real non-test code, get_bucket(validate=False) is called inside _get_or_create_bucket(), and with validate=False, no actual call ever goes to S3 that could return the S3ResponseError. Thus this is a no-op, but I think in this case you actually /do/ want it it actually check the buckets existence.

Also note that I'm trying to get S3Boto3 up to date with the commits, and figuring out how to properly emulate this is my last blocker to getting you an update pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.