Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added host setting to GSBotoStorage (fixes #124) #125

Merged
merged 1 commit into from Mar 1, 2016

Conversation

Projects
None yet
2 participants
@dcgoss
Copy link
Contributor

dcgoss commented Feb 29, 2016

GSBotoStorage inherits this method from its parent class, S3BotoStorage:

def connection(self):
        if self._connection is None:
            self._connection = self.connection_class(
                self.access_key,
                self.secret_key,
                is_secure=self.use_ssl,
                calling_format=self.calling_format,
                host=self.host,
                port=self.port,
                proxy=self.proxy,
                proxy_port=self.proxy_port
            )
        return self._connection

Note the host=self.host.

The value of this setting for GSBotoStorage used to be derived from S3BotoStorage as well. The value in the parent class was: host = setting('AWS_S3_HOST', S3Connection.DefaultHost), which resolved to 's3.amazonaws.com' instead of the correct 'storage.googleapis.com'.

This fixed #124 for me.

Added host setting to GSBotoStorage
The value of this setting used to be derived from the parent class, S3BotoStorage. The value in the parent class was: `host = setting('AWS_S3_HOST', S3Connection.DefaultHost)`, which resolved to 's3.amazonaws.com' instead of the correct 'storage.googleapis.com'.
This fixed #124 for me.

@dcgoss dcgoss changed the title Added host setting to GSBotoStorage, fixes #124 Added host setting to GSBotoStorage (fixes #124) Feb 29, 2016

@dcgoss

This comment has been minimized.

Copy link
Contributor Author

dcgoss commented Mar 1, 2016

This should also resolve #54, which is the same issue.

@dcgoss dcgoss referenced this pull request Mar 1, 2016

Closed

Bugfix gs connection #54

jschneier added a commit that referenced this pull request Mar 1, 2016

Merge pull request #125 from dcgoss/patch-1
Added host setting to GSBotoStorage (fixes #124)

@jschneier jschneier merged commit 84d346e into jschneier:master Mar 1, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@pyup-bot pyup-bot referenced this pull request Jul 27, 2016

Merged

Initial Update #344

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.